Re: [PATCH v3] sched/cputime: Protect some other sum_exec_runtime reads on 32 bit cpus

2016-09-07 Thread Peter Zijlstra
On Wed, Sep 07, 2016 at 08:38:27AM +0200, Stanislaw Gruszka wrote: > On Tue, Sep 06, 2016 at 09:01:29PM +0200, Peter Zijlstra wrote: > > On Tue, Sep 06, 2016 at 02:49:08PM +0200, Stanislaw Gruszka wrote: > > > diff --git a/kernel/exit.c b/kernel/exit.c > > > index 2f974ae..a46f96f 100644 > > > ---

Re: [PATCH v3] sched/cputime: Protect some other sum_exec_runtime reads on 32 bit cpus

2016-09-06 Thread Peter Zijlstra
On Tue, Sep 06, 2016 at 09:01:29PM +0200, Peter Zijlstra wrote: > > diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c > > index 39008d7..a2d753b 100644 > > --- a/kernel/time/posix-cpu-timers.c > > +++ b/kernel/time/posix-cpu-timers.c > > @@ -848,7 +848,7 @@ static void ch

Re: [PATCH v3] sched/cputime: Protect some other sum_exec_runtime reads on 32 bit cpus

2016-09-06 Thread Stanislaw Gruszka
On Tue, Sep 06, 2016 at 09:01:29PM +0200, Peter Zijlstra wrote: > On Tue, Sep 06, 2016 at 02:49:08PM +0200, Stanislaw Gruszka wrote: > > diff --git a/kernel/exit.c b/kernel/exit.c > > index 2f974ae..a46f96f 100644 > > --- a/kernel/exit.c > > +++ b/kernel/exit.c > > @@ -134,7 +134,7 @@ static void _

Re: [PATCH v3] sched/cputime: Protect some other sum_exec_runtime reads on 32 bit cpus

2016-09-06 Thread Peter Zijlstra
On Tue, Sep 06, 2016 at 02:49:08PM +0200, Stanislaw Gruszka wrote: > diff --git a/kernel/exit.c b/kernel/exit.c > index 2f974ae..a46f96f 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -134,7 +134,7 @@ static void __exit_signal(struct task_struct *tsk) > sig->inblock += task_io_get_in

[PATCH v3] sched/cputime: Protect some other sum_exec_runtime reads on 32 bit cpus

2016-09-06 Thread Stanislaw Gruszka
We protect 64bit sum_exec_runtime variable against inconsistency on 32 bit architectures when reading it on thread_group_cputime(), but we also read it on other places not protected. Patch changes that, except places where sum_exec_runtime is read for debuging purpose and where we also read some o