Re: [PATCH v3] sched: fix tsk->pi_lock isn't held when do_set_cpus_allowed()

2015-08-31 Thread Wanpeng Li
Ping Ingo, ;-) On 8/28/15 9:29 PM, Peter Zijlstra wrote: On Fri, Aug 28, 2015 at 02:55:56PM +0800, Wanpeng Li wrote: This patch fix it by following the rules for changing task_struct::cpus_allowed w/ both pi_lock and rq->lock are held. Thanks, I made that the below. There was a pin leak and I t

Re: [PATCH v3] sched: fix tsk->pi_lock isn't held when do_set_cpus_allowed()

2015-08-28 Thread Wanpeng Li
On 8/28/15 9:29 PM, Peter Zijlstra wrote: On Fri, Aug 28, 2015 at 02:55:56PM +0800, Wanpeng Li wrote: This patch fix it by following the rules for changing task_struct::cpus_allowed w/ both pi_lock and rq->lock are held. Thanks, I made that the below. There was a pin leak and I turned the safet

Re: [PATCH v3] sched: fix tsk->pi_lock isn't held when do_set_cpus_allowed()

2015-08-28 Thread Peter Zijlstra
On Fri, Aug 28, 2015 at 02:55:56PM +0800, Wanpeng Li wrote: > This patch fix it by following the rules for changing > task_struct::cpus_allowed > w/ both pi_lock and rq->lock are held. Thanks, I made that the below. There was a pin leak and I turned the safety check into a WARN_ON because it rea

[PATCH v3] sched: fix tsk->pi_lock isn't held when do_set_cpus_allowed()

2015-08-27 Thread Wanpeng Li
[ cut here ] WARNING: CPU: 0 PID: 13 at kernel/sched/core.c:1156 do_set_cpus_allowed+0x7e/0x80() Modules linked in: CPU: 0 PID: 13 Comm: migration/0 Not tainted 4.2.0-rc1-00049-g25834c7 #2 Call Trace: dump_stack+0x4b/0x75 warn_slowpath_common+0x8b/0xc0