Re: [PATCH v3] sched: keep quiescent cpu out of idle balance loop

2014-02-21 Thread Mike Galbraith
On Fri, 2014-02-21 at 17:15 +0800, Lei Wen wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 235cfa7..af30b6a 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -6883,6 +6883,14 @@ void nohz_balance_enter_idle(int cpu) > if (!cpu_active(cpu)) >

[PATCH v3] sched: keep quiescent cpu out of idle balance loop

2014-02-21 Thread Lei Wen
Cpu which is put into quiescent mode, would set its sd member as NULL, and want others not disturb its task running. But current scheduler would not checking whether that cpu is setting in such mode, and still insist the quiescent cpu to response the nohz load balance. Fix it by preventing such

[PATCH v3] sched: keep quiescent cpu out of idle balance loop

2014-02-21 Thread Lei Wen
Cpu which is put into quiescent mode, would set its sd member as NULL, and want others not disturb its task running. But current scheduler would not checking whether that cpu is setting in such mode, and still insist the quiescent cpu to response the nohz load balance. Fix it by preventing such

Re: [PATCH v3] sched: keep quiescent cpu out of idle balance loop

2014-02-21 Thread Mike Galbraith
On Fri, 2014-02-21 at 17:15 +0800, Lei Wen wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 235cfa7..af30b6a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6883,6 +6883,14 @@ void nohz_balance_enter_idle(int cpu) if (!cpu_active(cpu))