Re: [PATCH v3] scsi: NCR5380: Remove context check

2020-12-09 Thread Martin K. Petersen
On Sun, 6 Dec 2020 08:51:57 +0100, Ahmed S. Darwish wrote: > NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to > check if it is safe to sleep. > > Such usage in drivers is phased out and Linus clearly requested that > code which changes behaviour depending on context should eith

Re: [PATCH v3] scsi: NCR5380: Remove context check

2020-12-07 Thread Martin K. Petersen
Ahmed, > NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to > check if it is safe to sleep. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: NCR5380: Remove context check

2020-12-07 Thread Finn Thain
On Sun, 6 Dec 2020, Ahmed S. Darwish wrote: > NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to > check if it is safe to sleep. > > Such usage in drivers is phased out and Linus clearly requested that > code which changes behaviour depending on context should either be > separat

[PATCH v3] scsi: NCR5380: Remove context check

2020-12-05 Thread Ahmed S. Darwish
NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to check if it is safe to sleep. Such usage in drivers is phased out and Linus clearly requested that code which changes behaviour depending on context should either be separated, or the context be explicitly conveyed in an argument