Re: [PATCH v3] selftests/livepatch: introduce tests

On Mon 23-04-18 10:43:17, Joe Lawrence wrote: > On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: [...] > > > + > > > + # Wait for livepatch transition ... > > > + local i=0 > > > + while [[ $(cat /sys/kernel/livepatch/"$mod"/transition) != "0" ]]; do > > > + i=$((i+1)) > >

Re: [PATCH v3] selftests/livepatch: introduce tests

On Mon 23-04-18 10:43:17, Joe Lawrence wrote: > On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: [...] > > > + > > > + # Wait for livepatch transition ... > > > + local i=0 > > > + while [[ $(cat /sys/kernel/livepatch/"$mod"/transition) != "0" ]]; do > > > + i=$((i+1)) > >

Re: [PATCH v3] selftests/livepatch: introduce tests

On Tue 24-04-18 11:50:28, Joe Lawrence wrote: > On 04/23/2018 10:43 AM, Joe Lawrence wrote: > > On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: > >> On Thu 12-04-18 10:54:31, Joe Lawrence wrote: > >>> + fi > >>> + echo "$ret" > /dev/kmsg > >>> +} > >>> + > >>> +#

Re: [PATCH v3] selftests/livepatch: introduce tests

On Tue 24-04-18 11:50:28, Joe Lawrence wrote: > On 04/23/2018 10:43 AM, Joe Lawrence wrote: > > On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: > >> On Thu 12-04-18 10:54:31, Joe Lawrence wrote: > >>> + fi > >>> + echo "$ret" > /dev/kmsg > >>> +} > >>> + > >>> +#

Re: [PATCH v3] selftests/livepatch: introduce tests

On 04/23/2018 10:43 AM, Joe Lawrence wrote: > On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: >> On Thu 12-04-18 10:54:31, Joe Lawrence wrote: >>> + fi >>> + echo "$ret" > /dev/kmsg >>> +} >>> + >>> +# unload_mod(modname) - unload a kernel module >>> +# modname - module name

Re: [PATCH v3] selftests/livepatch: introduce tests

On 04/23/2018 10:43 AM, Joe Lawrence wrote: > On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: >> On Thu 12-04-18 10:54:31, Joe Lawrence wrote: >>> + fi >>> + echo "$ret" > /dev/kmsg >>> +} >>> + >>> +# unload_mod(modname) - unload a kernel module >>> +# modname - module name

Re: [PATCH v3] selftests/livepatch: introduce tests

On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: > Hi Joe, > > I know I am late to the party, yet have some questions about the code. Hi Libor, I'm planning another version, so you're comments are not too late! > On Thu 12-04-18 10:54:31, Joe Lawrence wrote: > > Add a few

Re: [PATCH v3] selftests/livepatch: introduce tests

On Fri, Apr 20, 2018 at 02:56:05PM +0200, Libor Pechacek wrote: > Hi Joe, > > I know I am late to the party, yet have some questions about the code. Hi Libor, I'm planning another version, so you're comments are not too late! > On Thu 12-04-18 10:54:31, Joe Lawrence wrote: > > Add a few

Re: [PATCH v3] selftests/livepatch: introduce tests

Hi Joe, I know I am late to the party, yet have some questions about the code. On Thu 12-04-18 10:54:31, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. > > Signed-off-by: Joe Lawrence

Re: [PATCH v3] selftests/livepatch: introduce tests

Hi Joe, I know I am late to the party, yet have some questions about the code. On Thu 12-04-18 10:54:31, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. > > Signed-off-by: Joe Lawrence > --- [...] > diff

Re: [PATCH v3] selftests/livepatch: introduce tests

On 04/17/2018 04:06 AM, Miroslav Benes wrote: > On Mon, 16 Apr 2018, Petr Mladek wrote: > >> On Mon 2018-04-16 13:33:55, Miroslav Benes wrote: >>> On Fri, 13 Apr 2018, Joe Lawrence wrote: Thanks for reviewing. I'll hold off on posting v4 until Petr (and others) get a chance to comment.

Re: [PATCH v3] selftests/livepatch: introduce tests

On 04/17/2018 04:06 AM, Miroslav Benes wrote: > On Mon, 16 Apr 2018, Petr Mladek wrote: > >> On Mon 2018-04-16 13:33:55, Miroslav Benes wrote: >>> On Fri, 13 Apr 2018, Joe Lawrence wrote: Thanks for reviewing. I'll hold off on posting v4 until Petr (and others) get a chance to comment.

Re: [PATCH v3] selftests/livepatch: introduce tests

On Mon, 16 Apr 2018, Petr Mladek wrote: > On Mon 2018-04-16 13:33:55, Miroslav Benes wrote: > > On Fri, 13 Apr 2018, Joe Lawrence wrote: > > > Thanks for reviewing. I'll hold off on posting v4 until Petr (and > > > others) get a chance to comment. Perhaps there are other tests that > > > would

Re: [PATCH v3] selftests/livepatch: introduce tests

On Mon, 16 Apr 2018, Petr Mladek wrote: > On Mon 2018-04-16 13:33:55, Miroslav Benes wrote: > > On Fri, 13 Apr 2018, Joe Lawrence wrote: > > > Thanks for reviewing. I'll hold off on posting v4 until Petr (and > > > others) get a chance to comment. Perhaps there are other tests that > > > would

Re: [PATCH v3] selftests/livepatch: introduce tests

On Mon 2018-04-16 13:33:55, Miroslav Benes wrote: > On Fri, 13 Apr 2018, Joe Lawrence wrote: > > Thanks for reviewing. I'll hold off on posting v4 until Petr (and > > others) get a chance to comment. Perhaps there are other tests that > > would be helpful? > I think it would be useful to have

Re: [PATCH v3] selftests/livepatch: introduce tests

On Mon 2018-04-16 13:33:55, Miroslav Benes wrote: > On Fri, 13 Apr 2018, Joe Lawrence wrote: > > Thanks for reviewing. I'll hold off on posting v4 until Petr (and > > others) get a chance to comment. Perhaps there are other tests that > > would be helpful? > I think it would be useful to have

Re: [PATCH v3] selftests/livepatch: introduce tests

On Thu 2018-04-12 10:54:31, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. > > > diff --git a/Documentation/livepatch/callbacks.txt > b/Documentation/livepatch/callbacks.txt > index

Re: [PATCH v3] selftests/livepatch: introduce tests

On Thu 2018-04-12 10:54:31, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. > > > diff --git a/Documentation/livepatch/callbacks.txt > b/Documentation/livepatch/callbacks.txt > index

Re: [PATCH v3] selftests/livepatch: introduce tests

On Fri, 13 Apr 2018, Joe Lawrence wrote: > On 04/13/2018 07:20 AM, Miroslav Benes wrote: > > Hi, > > > > On Thu, 12 Apr 2018, Joe Lawrence wrote: > > > >> Add a few livepatch modules and simple target modules that the included > >> regression suite can run tests against. > > > > Could you

Re: [PATCH v3] selftests/livepatch: introduce tests

On Fri, 13 Apr 2018, Joe Lawrence wrote: > On 04/13/2018 07:20 AM, Miroslav Benes wrote: > > Hi, > > > > On Thu, 12 Apr 2018, Joe Lawrence wrote: > > > >> Add a few livepatch modules and simple target modules that the included > >> regression suite can run tests against. > > > > Could you

Re: [PATCH v3] selftests/livepatch: introduce tests

On 04/13/2018 07:20 AM, Miroslav Benes wrote: > Hi, > > On Thu, 12 Apr 2018, Joe Lawrence wrote: > >> Add a few livepatch modules and simple target modules that the included >> regression suite can run tests against. > > Could you include a brief description which features are tested? I can

Re: [PATCH v3] selftests/livepatch: introduce tests

On 04/13/2018 07:20 AM, Miroslav Benes wrote: > Hi, > > On Thu, 12 Apr 2018, Joe Lawrence wrote: > >> Add a few livepatch modules and simple target modules that the included >> regression suite can run tests against. > > Could you include a brief description which features are tested? I can

Re: [PATCH v3] selftests/livepatch: introduce tests

Hi, On Thu, 12 Apr 2018, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. Could you include a brief description which features are tested? > Signed-off-by: Joe Lawrence > --- >

Re: [PATCH v3] selftests/livepatch: introduce tests

Hi, On Thu, 12 Apr 2018, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. Could you include a brief description which features are tested? > Signed-off-by: Joe Lawrence > --- > diff --git

Re: [PATCH v3] selftests/livepatch: introduce tests

On Thu, Apr 12, 2018 at 10:54:31AM -0400, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. > > Signed-off-by: Joe Lawrence (assuming it's merged after the other two patch sets it

Re: [PATCH v3] selftests/livepatch: introduce tests

On Thu, Apr 12, 2018 at 10:54:31AM -0400, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. > > Signed-off-by: Joe Lawrence (assuming it's merged after the other two patch sets it depends on) Acked-by: Josh

[PATCH v3] selftests/livepatch: introduce tests

Add a few livepatch modules and simple target modules that the included regression suite can run tests against. Signed-off-by: Joe Lawrence --- Documentation/livepatch/callbacks.txt | 487 - lib/Kconfig.debug

[PATCH v3] selftests/livepatch: introduce tests

Add a few livepatch modules and simple target modules that the included regression suite can run tests against. Signed-off-by: Joe Lawrence --- Documentation/livepatch/callbacks.txt | 487 - lib/Kconfig.debug | 12 + lib/Makefile