On Tue, Dec 22, 2015 at 12:15:18PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 22, 2015 at 12:08 PM, Sudip Mukherjee
> wrote:
> > On Tue, Dec 22, 2015 at 11:58:17AM +0200, Andy Shevchenko wrote:
>
> >> > The only downside is
> >> > that the module gets loaded even if the device is not there.
> >>
On Tue, Dec 22, 2015 at 12:08 PM, Sudip Mukherjee
wrote:
> On Tue, Dec 22, 2015 at 11:58:17AM +0200, Andy Shevchenko wrote:
>> > The only downside is
>> > that the module gets loaded even if the device is not there.
>>
>> How is that?
>
> Alan explained that in https://lkml.org/lkml/2015/12/20/10
On Tue, Dec 22, 2015 at 11:58:17AM +0200, Andy Shevchenko wrote:
> On Tue, Dec 22, 2015 at 6:27 AM, Sudip Mukherjee
> wrote:
> > On Mon, Dec 21, 2015 at 08:28:51PM +0200, Andy Shevchenko wrote:
> >> On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee
> >> wrote:
> >>
>
> >> There are at least two a
On Tue, Dec 22, 2015 at 6:27 AM, Sudip Mukherjee
wrote:
> On Mon, Dec 21, 2015 at 08:28:51PM +0200, Andy Shevchenko wrote:
>> On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee
>> wrote:
>>
>> There are at least two approaches:
>> - use 8250_pci, etc as a library (see example: 8250_mid.c)
>> - f
On Mon, Dec 21, 2015 at 08:28:51PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee
> wrote:
>
> > diff --git a/drivers/tty/serial/8250/Kconfig
> > b/drivers/tty/serial/8250/Kconfig
> > index 6412f14..ec3d287 100644
> > --- a/drivers/tty/serial/8250/Kconfig
> > ++
On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee
wrote:
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index 6412f14..ec3d287 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -378,3 +378,11 @@ config SERIAL_8250_MID
>
On Sun, Dec 20, 2015 at 05:42:08PM +, One Thousand Gnomes wrote:
> > So then should I rewrite it as MFD or should it be like the way you
> > suggested in the other mail to have it as bool in the Kconfig and combine
> > the file with 8250_pci.c when the symbol is selected?
>
> Yes although I'm
On Sun, Dec 20, 2015 at 7:28 PM, Sudip Mukherjee
wrote:
> On Sun, Dec 20, 2015 at 04:43:53PM +, One Thousand Gnomes wrote:
>> > v3: Alan commented on v2, few things like NULL check, name of the gpio
>> > chip,
>> > moving some more code into the gpio code. He also commented on it being
>> > a
> So then should I rewrite it as MFD or should it be like the way you
> suggested in the other mail to have it as bool in the Kconfig and combine
> the file with 8250_pci.c when the symbol is selected?
Yes although I'm really not sure which is the best approach of the two.
Alan
--
To unsubscribe
On Sun, Dec 20, 2015 at 04:43:53PM +, One Thousand Gnomes wrote:
> > v3: Alan commented on v2, few things like NULL check, name of the gpio chip,
> > moving some more code into the gpio code. He also commented on it being
> > a separate module, but since this will not be needed by someone who i
> > If you are linking it into the driver you don't need the module_init/exit
> > gpio_init/exit methods. Your Kconfig becomes a bool and you combine the
> > file into the driver based upon that bool.
>
> But isn't it better to have the gpio code separete from the 8250 code?
> But how do i combine
On Sun, Dec 20, 2015 at 04:41:31PM +, One Thousand Gnomes wrote:
> On Sun, 20 Dec 2015 20:17:22 +0530
> Sudip Mukherjee wrote:
>
> > On Sun, Dec 20, 2015 at 04:18:17PM +0200, Andy Shevchenko wrote:
> > > On Sun, Dec 20, 2015 at 3:24 PM, Sudip Mukherjee
> > > wrote:
> > > > Exar XR17V352/354/
> v3: Alan commented on v2, few things like NULL check, name of the gpio chip,
> moving some more code into the gpio code. He also commented on it being
> a separate module, but since this will not be needed by someone who is not
> using Exar chip, and even those who are using, some of them may not
On Sun, 20 Dec 2015 20:17:22 +0530
Sudip Mukherjee wrote:
> On Sun, Dec 20, 2015 at 04:18:17PM +0200, Andy Shevchenko wrote:
> > On Sun, Dec 20, 2015 at 3:24 PM, Sudip Mukherjee
> > wrote:
> > > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> > > can be controlled using
On Sun, Dec 20, 2015 at 4:47 PM, Sudip Mukherjee
wrote:
> On Sun, Dec 20, 2015 at 04:18:17PM +0200, Andy Shevchenko wrote:
>> On Sun, Dec 20, 2015 at 3:24 PM, Sudip Mukherjee
>> wrote:
>> > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
>> > can be controlled using gpio in
On Sun, Dec 20, 2015 at 04:18:17PM +0200, Andy Shevchenko wrote:
> On Sun, Dec 20, 2015 at 3:24 PM, Sudip Mukherjee
> wrote:
> > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> > can be controlled using gpio interface.
> > Add support to use these pins and select GPIO_SYSF
On Sun, Dec 20, 2015 at 3:24 PM, Sudip Mukherjee
wrote:
> Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> can be controlled using gpio interface.
> Add support to use these pins and select GPIO_SYSFS also so that these
> pins can be used from the userspace through sysfs.
>
Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
can be controlled using gpio interface.
Add support to use these pins and select GPIO_SYSFS also so that these
pins can be used from the userspace through sysfs.
Tested-by: Rob Groner
Signed-off-by: Sudip Mukherjee
---
v3: A
18 matches
Mail list logo
