Re: [PATCH v3] staging: rtl8188eu: Fix potential NULL pointer dereference of kcalloc

2019-03-20 Thread Mukesh Ojha
On 3/20/2019 10:51 PM, Aditya Pakki wrote: hwxmits is allocated via kcalloc and not checked for failure before its No need to mentionĀ  kcalloc as the other place allocates the memory through kmalloc. Otherwise looks good. Acked-by: Mukesh Ojha dereference. The patch fixes this problem

Re: [PATCH v3] staging: rtl8188eu: Fix potential NULL pointer dereference of kcalloc

2019-03-20 Thread Hans de Goede
Hi, On 20-03-19 18:21, Aditya Pakki wrote: hwxmits is allocated via kcalloc and not checked for failure before its dereference. The patch fixes this problem by returning error upstream in rtl8723bs, rtl8188eu. Signed-off-by: Aditya Pakki Patch look good to me: Reviewed-by: Hans de Goede

[PATCH v3] staging: rtl8188eu: Fix potential NULL pointer dereference of kcalloc

2019-03-20 Thread Aditya Pakki
hwxmits is allocated via kcalloc and not checked for failure before its dereference. The patch fixes this problem by returning error upstream in rtl8723bs, rtl8188eu. Signed-off-by: Aditya Pakki --- v2: Move signed off above version change log. v1: Return error and remove print in case of