Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-03 Thread Jarkko Sakkinen
On Wed, Feb 03, 2021 at 02:43:44PM +0100, Lukasz Majczak wrote: > Hi Jarkko, Dirk, > > Jarkko, > Thank you for your points - I will try to fix all you have mentioned. > I think it would be good to clarify a few things, before going with > the next version. Regarding use tpm_chip_start/stop()

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-03 Thread Lukasz Majczak
Hi Jarkko, Dirk, Jarkko, Thank you for your points - I will try to fix all you have mentioned. I think it would be good to clarify a few things, before going with the next version. Regarding use tpm_chip_start/stop() around tpm2_probe() call - I have followed the similar way it is done in the

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-03 Thread Dirk Gouders
Dirk Gouders writes: > Lukasz Majczak writes: > >> There are missing calls to tpm_request_locality before the calls to >> the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions >> internally send commands to the tpm. As the current >> approach might work for tpm2, it fails for

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Jarkko Sakkinen
On Wed, Feb 03, 2021 at 02:05:17AM +0200, Jarkko Sakkinen wrote: > On Tue, Feb 02, 2021 at 11:49:11PM +0200, Jarkko Sakkinen wrote: > > On Tue, Feb 02, 2021 at 04:51:39PM +0100, Lukasz Majczak wrote: > > > There are missing calls to tpm_request_locality before the calls to > > > the

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Jarkko Sakkinen
On Tue, Feb 02, 2021 at 11:49:11PM +0200, Jarkko Sakkinen wrote: > On Tue, Feb 02, 2021 at 04:51:39PM +0100, Lukasz Majczak wrote: > > There are missing calls to tpm_request_locality before the calls to > > the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions > > internally send

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Jarkko Sakkinen
On Tue, Feb 02, 2021 at 08:29:50AM -0800, Guenter Roeck wrote: > On Tue, Feb 02, 2021 at 04:51:39PM +0100, Lukasz Majczak wrote: > > There are missing calls to tpm_request_locality before the calls to > > the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions > > internally send

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Jarkko Sakkinen
On Tue, Feb 02, 2021 at 04:51:39PM +0100, Lukasz Majczak wrote: > There are missing calls to tpm_request_locality before the calls to > the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions > internally send commands to the tpm. As the current > approach might work for tpm2, it

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Dirk Gouders
Lukasz Majczak writes: > There are missing calls to tpm_request_locality before the calls to > the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions > internally send commands to the tpm. As the current > approach might work for tpm2, it fails for tpm1.x - in that case > call to

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Guenter Roeck
On Tue, Feb 02, 2021 at 04:51:39PM +0100, Lukasz Majczak wrote: > There are missing calls to tpm_request_locality before the calls to > the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions > internally send commands to the tpm. As the current > approach might work for tpm2, it

[PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Lukasz Majczak
There are missing calls to tpm_request_locality before the calls to the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions internally send commands to the tpm. As the current approach might work for tpm2, it fails for tpm1.x - in that case call to tpm_get_timeouts() or