> -Original Message-
> From: Masami Hiramatsu
> Sent: Wednesday, January 27, 2021 9:28 PM
> To: Jianlin Lv
> Cc: Oleg Nesterov ; Steven Rostedt
> ; mi...@redhat.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] tracing: precise log info for kretprobe ad
nux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v3] tracing: precise log info for kretprobe addr err
> >
> > On Tue, 26 Jan 2021 21:20:59 +0100
> > Oleg Nesterov wrote:
> >
> > > On 01/26, Masami Hiramatsu wrote:
> > > >
> > > > >
On Tue, 26 Jan 2021 21:20:59 +0100
Oleg Nesterov wrote:
> On 01/26, Masami Hiramatsu wrote:
> >
> > > >
> > > > IOW, the "offset != 0" check removed by this patch is obviously wrong,
> > > > right?
> > > >
> >
> > No, not wrong. Even offset != 0, if the symbol exists in the kernel,
> >
On Tue, 26 Jan 2021 21:20:59 +0100
Oleg Nesterov wrote:
> > No, not wrong. Even offset != 0, if the symbol exists in the kernel,
> > kprobe_on_func_entry() will check it.
>
> Yes, but unless I am totally confused... if kprobe_on_func_entry() returns
> false,
> then trace_kprobe_create()
On Tue, 26 Jan 2021 16:40:38 -0500
Steven Rostedt wrote:
> On Tue, 26 Jan 2021 22:17:23 +0100
> Oleg Nesterov wrote:
>
> > On 01/26, Steven Rostedt wrote:
> > >
> > > On Tue, 26 Jan 2021 21:20:59 +0100
> > > Oleg Nesterov wrote:
> > >
> > > > > No, not wrong. Even offset != 0, if the symbol
> -Original Message-
> From: Masami Hiramatsu
> Sent: Wednesday, January 27, 2021 10:02 AM
> To: Oleg Nesterov
> Cc: Steven Rostedt ; Jianlin Lv ;
> mi...@redhat.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] tracing: precise log info for kretprobe ad
On Tue, 26 Jan 2021 22:17:23 +0100
Oleg Nesterov wrote:
> On 01/26, Steven Rostedt wrote:
> >
> > On Tue, 26 Jan 2021 21:20:59 +0100
> > Oleg Nesterov wrote:
> >
> > > > No, not wrong. Even offset != 0, if the symbol exists in the kernel,
> > > > kprobe_on_func_entry() will check it.
> > >
On 01/26, Steven Rostedt wrote:
>
> On Tue, 26 Jan 2021 21:20:59 +0100
> Oleg Nesterov wrote:
>
> > > No, not wrong. Even offset != 0, if the symbol exists in the kernel,
> > > kprobe_on_func_entry() will check it.
> >
> > Yes, but unless I am totally confused... if kprobe_on_func_entry() returns
On 01/26, Masami Hiramatsu wrote:
>
> > >
> > > IOW, the "offset != 0" check removed by this patch is obviously wrong,
> > > right?
> > >
>
> No, not wrong. Even offset != 0, if the symbol exists in the kernel,
> kprobe_on_func_entry() will check it.
Yes, but unless I am totally confused... if
> -Original Message-
> From: Masami Hiramatsu
> Sent: Tuesday, January 26, 2021 12:16 PM
> To: Steven Rostedt
> Cc: Oleg Nesterov ; Jianlin Lv ;
> mi...@redhat.com; mhira...@kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] tracing: precise log in
On Mon, 25 Jan 2021 13:38:40 -0500
Steven Rostedt wrote:
> On Mon, 25 Jan 2021 19:19:27 +0100
> Oleg Nesterov wrote:
>
> > On 01/26, Jianlin Lv wrote:
> > >
> > > When trying to create kretprobe with the wrong function symbol in tracefs;
> > > The error is triggered in the
When trying to create kretprobe with the wrong function symbol in tracefs;
The error is triggered in the register_trace_kprobe() and recorded as
FAIL_REG_PROBE issue,
Example:
$ cd /sys/kernel/debug/tracing
$ echo 'r:myprobe ERROR_SYMBOL_XXX ret=%x0' >> kprobe_events
bash: echo: write
On Mon, 25 Jan 2021 19:19:27 +0100
Oleg Nesterov wrote:
> On 01/26, Jianlin Lv wrote:
> >
> > When trying to create kretprobe with the wrong function symbol in tracefs;
> > The error is triggered in the register_trace_kprobe() and recorded as
> > FAIL_REG_PROBE issue,
> >
> > Example:
> > $ cd
On 01/26, Jianlin Lv wrote:
>
> When trying to create kretprobe with the wrong function symbol in tracefs;
> The error is triggered in the register_trace_kprobe() and recorded as
> FAIL_REG_PROBE issue,
>
> Example:
> $ cd /sys/kernel/debug/tracing
> $ echo 'r:myprobe ERROR_SYMBOL_XXX ret=%x0'
14 matches
Mail list logo
