Re: [PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Peter Chen
On Wed, Nov 18, 2015 at 09:30:39AM +0530, Saurabh Sengar wrote: > Hi Peter, > > Yes itc_setting is still optional, in case dts does not pass this > property, return type will be -EINVAL and there would be no problem. > The function will break only if there is 'No data'(-ENODATA) or >

Re: [PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
Hi Peter, Yes itc_setting is still optional, in case dts does not pass this property, return type will be -EINVAL and there would be no problem. The function will break only if there is 'No data'(-ENODATA) or 'overflow'(-ENODATA) error for this property. In case this is not OK, I will send a

Re: [PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Peter Chen
On Tue, Nov 17, 2015 at 05:22:26PM +0530, Saurabh Sengar wrote: > call to of_find_property() before of_property_read_u32() is unnecessary. > of_property_read_u32() anyway calls to of_find_property() only. > > Signed-off-by: Saurabh Sengar > --- > v2 : removed pval variable > v3 : removed

[PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2 : removed pval variable v3 : removed unnecessary if condition drivers/usb/chipidea/core.c | 59

[PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2 : removed pval variable v3 : removed unnecessary if condition drivers/usb/chipidea/core.c | 59

Re: [PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Peter Chen
On Wed, Nov 18, 2015 at 09:30:39AM +0530, Saurabh Sengar wrote: > Hi Peter, > > Yes itc_setting is still optional, in case dts does not pass this > property, return type will be -EINVAL and there would be no problem. > The function will break only if there is 'No data'(-ENODATA) or >

Re: [PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
Hi Peter, Yes itc_setting is still optional, in case dts does not pass this property, return type will be -EINVAL and there would be no problem. The function will break only if there is 'No data'(-ENODATA) or 'overflow'(-ENODATA) error for this property. In case this is not OK, I will send a

Re: [PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Peter Chen
On Tue, Nov 17, 2015 at 05:22:26PM +0530, Saurabh Sengar wrote: > call to of_find_property() before of_property_read_u32() is unnecessary. > of_property_read_u32() anyway calls to of_find_property() only. > > Signed-off-by: Saurabh Sengar > --- > v2 : removed pval