Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-16 Thread Felipe Balbi
Hi, On Sun, Dec 15, 2013 at 11:24:12PM +0100, Andreas Larsson wrote: > >>>Also, the way you're using thread IRQs is quite wrong. I can't let that > >>>pass and get merged upstream, sorry. > >> > >>What is quite wrong? What is it that I need to fix? > > > >Ideally the hardirq handler should be

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-16 Thread Felipe Balbi
Hi, On Sun, Dec 15, 2013 at 11:24:12PM +0100, Andreas Larsson wrote: Also, the way you're using thread IRQs is quite wrong. I can't let that pass and get merged upstream, sorry. What is quite wrong? What is it that I need to fix? Ideally the hardirq handler should be usually to actually

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-15 Thread Andreas Larsson
On 12/13/2013 08:52 PM, Felipe Balbi wrote: Hi, On Fri, Dec 13, 2013 at 08:48:30AM +0100, Andreas Larsson wrote: On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status)

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-15 Thread Andreas Larsson
On 12/13/2013 08:52 PM, Felipe Balbi wrote: Hi, On Fri, Dec 13, 2013 at 08:48:30AM +0100, Andreas Larsson wrote: On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status)

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-13 Thread Felipe Balbi
Hi, On Fri, Dec 13, 2013 at 08:48:30AM +0100, Andreas Larsson wrote: > >On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: > >>+static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, > >>+ int status) > >>+{ > >>+ struct gr_udc *dev; > >>+

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-13 Thread Felipe Balbi
Hi, On Fri, Dec 13, 2013 at 08:48:30AM +0100, Andreas Larsson wrote: On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +{ + struct gr_udc *dev; + +

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-12 Thread Andreas Larsson
On 2013-12-12 19:01, Felipe Balbi wrote: Hi, On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +{ + struct gr_udc *dev; + + list_del_init(>queue); + +

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-12 Thread Felipe Balbi
Hi, On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: > +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, > + int status) > +{ > + struct gr_udc *dev; > + > + list_del_init(>queue); > + > + if (likely(req->req.status ==

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-12 Thread Felipe Balbi
Hi, On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +{ + struct gr_udc *dev; + + list_del_init(req-queue); + + if (likely(req-req.status ==

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-12 Thread Andreas Larsson
On 2013-12-12 19:01, Felipe Balbi wrote: Hi, On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +{ + struct gr_udc *dev; + + list_del_init(req-queue); +