RE: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep

2015-12-17 Thread Du, Changbin
> > > > diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h > > index 3d583a1..0c5d9ea 100644 > > --- a/include/linux/usb/gadget.h > > +++ b/include/linux/usb/gadget.h > > @@ -402,6 +402,9 @@ static inline void usb_ep_free_request(struct > usb_ep *ep, > > static inline int usb_ep_

Re: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep

2015-12-17 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > From: "Du, Changbin" > > Queue a request to disabled ep doesn't make sense, and induce caller > make mistakes. > > Here is a example for the android mtp gadget function driver. A mem > corruption can happen on below senario. > 1) On disconnect, mtp driver dis

[PATCH v3] usb: gadget: forbid queuing request to a disabled ep

2015-12-17 Thread changbin . du
From: "Du, Changbin" Queue a request to disabled ep doesn't make sense, and induce caller make mistakes. Here is a example for the android mtp gadget function driver. A mem corruption can happen on below senario. 1) On disconnect, mtp driver disable its EPs, 2) During send_file_work and receive