> > @@ -913,6 +929,7 @@ static int tower_probe (struct usb_interface
> > *interface, const struct usb_device
>
> Don't you need to free get_version_reply here?
>
> > return retval;
> >
> > error:
> > + kfree(get_version_reply);
> > tower_delete(dev);
> > return retval;
> > }
> > @@ -913,6 +929,7 @@ static int tower_probe (struct usb_interface
> > *interface, const struct usb_device
>
> Don't you need to free get_version_reply here?
>
> > return retval;
> >
> > error:
> > + kfree(get_version_reply);
> > tower_delete(dev);
> > return retval;
> > }
Hi Maksim,
Sorry for commenting this so late but..
On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote:
> @@ -806,7 +814,7 @@ static int tower_probe (struct usb_interface *interface,
> const struct usb_device
> struct device *idev = >dev;
> struct usb_device *udev =
Hi Maksim,
Sorry for commenting this so late but..
On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote:
> @@ -806,7 +814,7 @@ static int tower_probe (struct usb_interface *interface,
> const struct usb_device
> struct device *idev = >dev;
> struct usb_device *udev =
> >* removed Tested-by: Alfredo Rafael Vicente Boix ;
>
> I added this back, as it matters, and your change from the previous
> version was trivial.
>
> >* removed Cc: sta...@vger.kernel.org
> > since this patch doesn't apply against v4.10.12
>
> I
> >* removed Tested-by: Alfredo Rafael Vicente Boix ;
>
> I added this back, as it matters, and your change from the previous
> version was trivial.
>
> >* removed Cc: sta...@vger.kernel.org
> > since this patch doesn't apply against v4.10.12
>
> I added this back as well
On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote:
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().
>
> Signed-off-by: Maksim Salau
> Tested-by: Alfredo Rafael Vicente Boix ;
On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote:
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().
>
> Signed-off-by: Maksim Salau
> Tested-by: Alfredo Rafael Vicente Boix ;
> Cc: stable
>
> ---
> Changes in v3:
>
Allocate buffers on HEAP instead of STACK for local structures
that are to be received using usb_control_msg().
Signed-off-by: Maksim Salau
---
Changes in v3:
* rebased against usb-next;
* removed Tested-by: Alfredo Rafael Vicente Boix ;
*
Allocate buffers on HEAP instead of STACK for local structures
that are to be received using usb_control_msg().
Signed-off-by: Maksim Salau
---
Changes in v3:
* rebased against usb-next;
* removed Tested-by: Alfredo Rafael Vicente Boix ;
* removed Cc: sta...@vger.kernel.org
10 matches
Mail list logo