Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver

2013-11-26 Thread Michal Simek
On 11/26/2013 09:19 AM, Geert Uytterhoeven wrote: > On Tue, Nov 26, 2013 at 8:10 AM, Michal Simek wrote: >> On 11/22/2013 05:34 AM, Stefan Kristiansson wrote: >> This construction seems to me too complicated and can be simpler. >> >> What about this? >> res = platform_get_resource(pdev, IO

Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver

2013-11-26 Thread Geert Uytterhoeven
On Tue, Nov 26, 2013 at 8:10 AM, Michal Simek wrote: > On 11/22/2013 05:34 AM, Stefan Kristiansson wrote: > This construction seems to me too complicated and can be simpler. > > What about this? > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); Don't forget to check for res being no

Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver

2013-11-26 Thread Stefan Kristiansson
On Tue, Nov 26, 2013 at 08:10:46AM +0100, Michal Simek wrote: > On 11/22/2013 05:34 AM, Stefan Kristiansson wrote: > > + > > + /* Request I/O resource */ > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res) { > > + dev_err(&pdev->dev, "I/O resource request fai

Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver

2013-11-25 Thread Michal Simek
On 11/22/2013 05:34 AM, Stefan Kristiansson wrote: > This adds support for the VGA/LCD core available from OpenCores: > http://opencores.org/project,vga_lcd > > The driver have been tested together with both OpenRISC and > ARM (socfpga) processors. > > Signed-off-by: Stefan Kristiansson > --- >

Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver

2013-11-25 Thread Stefan Kristiansson
On Sun, Nov 24, 2013 at 03:12:11PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 06:34 Fri 22 Nov , Stefan Kristiansson wrote: > > This adds support for the VGA/LCD core available from OpenCores: > > http://opencores.org/project,vga_lcd > > > > The driver have been tested together with

Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver

2013-11-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 06:34 Fri 22 Nov , Stefan Kristiansson wrote: > This adds support for the VGA/LCD core available from OpenCores: > http://opencores.org/project,vga_lcd > > The driver have been tested together with both OpenRISC and > ARM (socfpga) processors. > > Signed-off-by: Stefan Kristiansson Tomi