Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-08-03 Thread Minfei Huang
Hi, Michael. Since Stefan and Cornelia have review-acked this patch, could you mind helping review this patch? Thanks Minfei > On Jul 29, 2016, at 16:26, Stefan Hajnoczi wrote: > > On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang wrote: >> From: Minfei

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-08-03 Thread Minfei Huang
Hi, Michael. Since Stefan and Cornelia have review-acked this patch, could you mind helping review this patch? Thanks Minfei > On Jul 29, 2016, at 16:26, Stefan Hajnoczi wrote: > > On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang wrote: >> From: Minfei Huang >> >> We do a lot of memory

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-29 Thread Stefan Hajnoczi
On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang wrote: > From: Minfei Huang > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-29 Thread Stefan Hajnoczi
On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang wrote: > From: Minfei Huang > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that moment, >

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-22 Thread Minfei Huang
Ping, Any comment is appreciate. Thanks Minfei > On Jul 19, 2016, at 20:22, Cornelia Huck wrote: > > On Tue, 19 Jul 2016 12:32:42 +0800 > Minfei Huang wrote: > >> From: Minfei Huang >> >> We do a lot of memory allocation in

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-22 Thread Minfei Huang
Ping, Any comment is appreciate. Thanks Minfei > On Jul 19, 2016, at 20:22, Cornelia Huck wrote: > > On Tue, 19 Jul 2016 12:32:42 +0800 > Minfei Huang wrote: > >> From: Minfei Huang >> >> We do a lot of memory allocation in function init_vq, and don't handle >> the allocation failure

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-19 Thread Cornelia Huck
On Tue, 19 Jul 2016 12:32:42 +0800 Minfei Huang wrote: > From: Minfei Huang > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-19 Thread Cornelia Huck
On Tue, 19 Jul 2016 12:32:42 +0800 Minfei Huang wrote: > From: Minfei Huang > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that moment, >

[PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-18 Thread Minfei Huang
From: Minfei Huang We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is

[PATCH v3] virtio_blk: Fix a slient kernel panic

2016-07-18 Thread Minfei Huang
From: Minfei Huang We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk.