Re: [PATCH v3] vsprintf: don't obfuscate NULL and error pointers

2020-05-20 Thread Petr Mladek
On Tue 2020-05-19 11:36:52, Linus Torvalds wrote: > On Tue, May 19, 2020 at 4:27 AM Ilya Dryomov wrote: > > > > This just came up again, please consider sending this to Linus > > for 5.7. > > I just took it directly, since I like it and it looks trivial. Great, I am happy that it has got

Re: [PATCH v3] vsprintf: don't obfuscate NULL and error pointers

2020-05-19 Thread Linus Torvalds
On Tue, May 19, 2020 at 4:27 AM Ilya Dryomov wrote: > > This just came up again, please consider sending this to Linus > for 5.7. I just took it directly, since I like it and it looks trivial. Linus

Re: [PATCH v3] vsprintf: don't obfuscate NULL and error pointers

2020-05-19 Thread Andy Shevchenko
On Tue, May 19, 2020 at 01:26:57PM +0200, Ilya Dryomov wrote: > I don't see what security concern is addressed by obfuscating NULL > and IS_ERR() error pointers, printed with %p/%pK. Given the number > of sites where %p is used (over 1) and the fact that NULL pointers > aren't uncommon, it

[PATCH v3] vsprintf: don't obfuscate NULL and error pointers

2020-05-19 Thread Ilya Dryomov
I don't see what security concern is addressed by obfuscating NULL and IS_ERR() error pointers, printed with %p/%pK. Given the number of sites where %p is used (over 1) and the fact that NULL pointers aren't uncommon, it probably wouldn't take long for an attacker to find the hash that