Re: [PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-03-26 Thread Linn Crosetto
On Wed, Mar 26, 2014 at 10:04:52AM -0700, Yinghai Lu wrote: > On Wed, Mar 26, 2014 at 9:50 AM, Linn Crosetto wrote: > > On Tue, Mar 25, 2014 at 05:18:53PM -0700, Yinghai Lu wrote: > > > > Just noting that not all bits above first_system_vector are set in the > > bitmap, > > so the comment in asm/

Re: [PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-03-26 Thread Yinghai Lu
On Wed, Mar 26, 2014 at 9:50 AM, Linn Crosetto wrote: > On Tue, Mar 25, 2014 at 05:18:53PM -0700, Yinghai Lu wrote: > > Just noting that not all bits above first_system_vector are set in the bitmap, > so the comment in asm/desc.h and the change log could be misleading: > > /* used_vectors is BITMA

Re: [PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-03-26 Thread Linn Crosetto
On Tue, Mar 25, 2014 at 05:18:53PM -0700, Yinghai Lu wrote: > On Tue, Mar 25, 2014 at 1:03 PM, Linn Crosetto wrote: > > Thanks for the patch. > > > > On Tue, Jan 28, 2014 at 01:54:05PM -0800, Yinghai Lu wrote: > >> used_vectors is a bitmap for vectors that are not tracked in per_cpu > >> vector_ir

Re: [PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-03-25 Thread Yinghai Lu
On Tue, Mar 25, 2014 at 1:03 PM, Linn Crosetto wrote: > Thanks for the patch. > > On Tue, Jan 28, 2014 at 01:54:05PM -0800, Yinghai Lu wrote: >> used_vectors is a bitmap for vectors that are not tracked in per_cpu >> vector_irq. > > I feel like this comment (also in the code) could be misleading b

Re: [PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-03-25 Thread Linn Crosetto
Thanks for the patch. On Tue, Jan 28, 2014 at 01:54:05PM -0800, Yinghai Lu wrote: > used_vectors is a bitmap for vectors that are not tracked in per_cpu > vector_irq. I feel like this comment (also in the code) could be misleading because vectors above first_system_vector are effectively not trac

Re: [PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-02-06 Thread Prarit Bhargava
On 01/28/2014 04:54 PM, Yinghai Lu wrote: > used_vectors is a bitmap for vectors that are not tracked in per_cpu > vector_irq. > used_vectors contains information on the first 32 exceptions, the system > vectors. > the IA32_SYSCALL_VECTOR (0x80), and the IRQ_MOVE_CLEANUP_VECTOR (0x20). > > assi

Re: [PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-01-31 Thread Prarit Bhargava
On 01/28/2014 04:54 PM, Yinghai Lu wrote: > used_vectors is a bitmap for vectors that are not tracked in per_cpu > vector_irq. > used_vectors contains information on the first 32 exceptions, the system > vectors. > the IA32_SYSCALL_VECTOR (0x80), and the IRQ_MOVE_CLEANUP_VECTOR (0x20). > > assi

[PATCH v3] x86, irq: get correct available vectors for cpu disable

2014-01-28 Thread Yinghai Lu
used_vectors is a bitmap for vectors that are not tracked in per_cpu vector_irq. used_vectors contains information on the first 32 exceptions, the system vectors. the IA32_SYSCALL_VECTOR (0x80), and the IRQ_MOVE_CLEANUP_VECTOR (0x20). assign_irq_vectors() assigns vectors up to first_system_vector