Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread Ingo Molnar
* Stephen Warren wrote: > On 12/19/2013 11:55 AM, Ingo Molnar wrote: > > > > * Stephen Warren wrote: > > > >> On 12/19/2013 03:13 AM, David Herrmann wrote: > >>> With CONFIG_X86_SYSFB=y, probing real hw-drivers may result in > >>> resource-conflicts and drivers will refuse to load. A call to

Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread Stephen Warren
On 12/19/2013 11:55 AM, Ingo Molnar wrote: > > * Stephen Warren wrote: > >> On 12/19/2013 03:13 AM, David Herrmann wrote: >>> With CONFIG_X86_SYSFB=y, probing real hw-drivers may result in >>> resource-conflicts and drivers will refuse to load. A call to >>> request_mem_region() will fail, if th

Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread Ingo Molnar
* Stephen Warren wrote: > On 12/19/2013 03:13 AM, David Herrmann wrote: > > With CONFIG_X86_SYSFB=y, probing real hw-drivers may result in > > resource-conflicts and drivers will refuse to load. A call to > > request_mem_region() will fail, if the region overlaps with the mem-region > > used by

Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread Stephen Warren
On 12/19/2013 03:13 AM, David Herrmann wrote: > With CONFIG_X86_SYSFB=y, probing real hw-drivers may result in > resource-conflicts and drivers will refuse to load. A call to > request_mem_region() will fail, if the region overlaps with the mem-region > used by simplefb. The common desktop DRM driv

Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread David Herrmann
Hi On Thu, Dec 19, 2013 at 6:09 PM, Ingo Molnar wrote: > > * David Herrmann wrote: > >> Hi >> >> On Thu, Dec 19, 2013 at 5:36 PM, Ingo Molnar wrote: >> > >> > * David Herrmann wrote: >> > >> >> --- a/drivers/video/fbmem.c >> >> +++ b/drivers/video/fbmem.c >> >> @@ -35,6 +35,9 @@ >> >> >> >> #

Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread Ingo Molnar
* David Herrmann wrote: > Hi > > On Thu, Dec 19, 2013 at 5:36 PM, Ingo Molnar wrote: > > > > * David Herrmann wrote: > > > >> --- a/drivers/video/fbmem.c > >> +++ b/drivers/video/fbmem.c > >> @@ -35,6 +35,9 @@ > >> > >> #include > >> > >> +#if IS_ENABLED(CONFIG_X86) > >> +#include > >> +#e

Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread David Herrmann
Hi On Thu, Dec 19, 2013 at 5:36 PM, Ingo Molnar wrote: > > * David Herrmann wrote: > >> --- a/drivers/video/fbmem.c >> +++ b/drivers/video/fbmem.c >> @@ -35,6 +35,9 @@ >> >> #include >> >> +#if IS_ENABLED(CONFIG_X86) >> +#include >> +#endif > > I think this can be written as: > > #ifdef CONFI

Re: [PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread Ingo Molnar
* David Herrmann wrote: > --- a/drivers/video/fbmem.c > +++ b/drivers/video/fbmem.c > @@ -35,6 +35,9 @@ > > #include > > +#if IS_ENABLED(CONFIG_X86) > +#include > +#endif I think this can be written as: #ifdef CONFIG_X86 # include #endif also ... the dependency on a large, unrelated o

[PATCH v3] x86: sysfb: remove sysfb when probing real hw

2013-12-19 Thread David Herrmann
With CONFIG_X86_SYSFB=y, probing real hw-drivers may result in resource-conflicts and drivers will refuse to load. A call to request_mem_region() will fail, if the region overlaps with the mem-region used by simplefb. The common desktop DRM drivers (intel, nouveau, radeon) are not affected as they