Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/03/2015 08:52 PM, Yinghai Lu wrote: > On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley > wrote: >> On 04/03/2015 01:44 PM, Yinghai Lu wrote: >>> On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley >>> wrote: On 04/03/2015 12:57 PM, Yinghai Lu wrote: Wait -- you have earlycon in a

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley wrote: > On 04/03/2015 01:44 PM, Yinghai Lu wrote: > > which means you have to have CONFIG_SERIAL_EARLYCON to get a serial console > at all. what do you mean? Now in drivers/tty/serial/8250/Kconfig we have config SERIAL_8250_CONSOLE bool

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley wrote: > On 04/03/2015 01:44 PM, Yinghai Lu wrote: >> On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley >> wrote: >>> On 04/03/2015 12:57 PM, Yinghai Lu wrote: >>> >>> Wait -- you have earlycon in a product?? >> >> What do you mean? > > I mean, what

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Greg Kroah-Hartman
On Fri, Apr 03, 2015 at 02:27:30PM -0400, Peter Hurley wrote: > I have no problem fixing this _if this is causing actual regressions_, > and not simply some minor inconvenience that can be fixed by editing your > grub command line. But, you can't break working command lines from previous kernel

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/03/2015 01:44 PM, Yinghai Lu wrote: > On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley > wrote: >> On 04/03/2015 12:57 PM, Yinghai Lu wrote: >> >> Wait -- you have earlycon in a product?? > > What do you mean? I mean, what will happen if I put in a big debug banner like Steven did for

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley wrote: > On 04/03/2015 12:57 PM, Yinghai Lu wrote: > > Wait -- you have earlycon in a product?? What do you mean? when you are using "console=uart8250,io,0x3f8" you will have earlycon at first, and handover to console. -- To unsubscribe from this

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/03/2015 12:57 PM, Yinghai Lu wrote: > On Fri, Apr 3, 2015 at 3:37 AM, Peter Hurley wrote: >> On 04/02/2015 10:38 PM, Yinghai Lu wrote: >>> On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu wrote: >>> >>> still have another problem. >>> when using console=uart8250,io,0x3f8 >>> it works

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 3:37 AM, Peter Hurley wrote: > On 04/02/2015 10:38 PM, Yinghai Lu wrote: >> On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu wrote: >> >> still have another problem. >> when using console=uart8250,io,0x3f8 >> it works as earlycon at first. >> but after handover

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/02/2015 10:38 PM, Yinghai Lu wrote: > On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu wrote: > > still have another problem. > when using console=uart8250,io,0x3f8 > it works as earlycon at first. > but after handover to normal console > it will revert back to 9600 again.

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/02/2015 10:38 PM, Yinghai Lu wrote: On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu ying...@kernel.org wrote: still have another problem. when using console=uart8250,io,0x3f8 it works as earlycon at first. but after handover to normal console it will revert back to 9600 again. this

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 3:37 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/02/2015 10:38 PM, Yinghai Lu wrote: On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu ying...@kernel.org wrote: still have another problem. when using console=uart8250,io,0x3f8 it works as earlycon at first. but

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/03/2015 12:57 PM, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 3:37 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/02/2015 10:38 PM, Yinghai Lu wrote: On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu ying...@kernel.org wrote: still have another problem. when using

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Greg Kroah-Hartman
On Fri, Apr 03, 2015 at 02:27:30PM -0400, Peter Hurley wrote: I have no problem fixing this _if this is causing actual regressions_, and not simply some minor inconvenience that can be fixed by editing your grub command line. But, you can't break working command lines from previous kernel

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/03/2015 12:57 PM, Yinghai Lu wrote: Wait -- you have earlycon in a product?? What do you mean? when you are using console=uart8250,io,0x3f8 you will have earlycon at first, and handover to console. -- To

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/03/2015 01:44 PM, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/03/2015 12:57 PM, Yinghai Lu wrote: Wait -- you have earlycon in a product?? What do you mean? I mean, what will happen if I put in a big debug banner like Steven

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/03/2015 01:44 PM, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/03/2015 12:57 PM, Yinghai Lu wrote: Wait -- you have earlycon in a product?? What do

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/03/2015 01:44 PM, Yinghai Lu wrote: which means you have to have CONFIG_SERIAL_EARLYCON to get a serial console at all. what do you mean? Now in drivers/tty/serial/8250/Kconfig we have config

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-03 Thread Peter Hurley
On 04/03/2015 08:52 PM, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/03/2015 01:44 PM, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 04/03/2015 12:57 PM, Yinghai Lu wrote: Wait

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu wrote: still have another problem. when using console=uart8250,io,0x3f8 it works as earlycon at first. but after handover to normal console it will revert back to 9600 again. >>> >>> this regression should be caused by: >>> >>>

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 5:02 PM, Yinghai Lu wrote: > On Thu, Apr 2, 2015 at 3:36 PM, Yinghai Lu wrote: >> On Thu, Apr 2, 2015 at 3:12 PM, Yinghai Lu wrote: >>> On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu wrote: On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley wrote: > Would you

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 3:36 PM, Yinghai Lu wrote: > On Thu, Apr 2, 2015 at 3:12 PM, Yinghai Lu wrote: >> On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu wrote: >>> On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley >>> wrote: >>> Would you please try the patch below instead? >>> Great. that

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 3:12 PM, Yinghai Lu wrote: > On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu wrote: >> On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley >> wrote: >> >>> Would you please try the patch below instead? >>> >> Great. that works, and less lines change than my version. >> > > still

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu wrote: > On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley wrote: > >> Would you please try the patch below instead? >> > Great. that works, and less lines change than my version. > still have another problem. when using console=uart8250,io,0x3f8 it works

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley wrote: > Would you please try the patch below instead? > > --- >% --- > From: Peter Hurley > Subject: [PATCH] earlycon: Fix __earlycon_table stride > > Signed-off-by: Peter Hurley > --- > include/asm-generic/vmlinux.lds.h | 2 +- >

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Peter Hurley
Hi Yinghai, On 04/02/2015 05:15 AM, Yinghai Lu wrote: > On Wed, Apr 1, 2015 at 8:22 PM, Peter Hurley wrote: >> The documented behavior of console=ttyS options, to which your >> quote refers, clearly states: >> >> Default is "9600n8". > >

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Wed, Apr 1, 2015 at 8:22 PM, Peter Hurley wrote: > The documented behavior of console=ttyS options, to which your > quote refers, clearly states: > > Default is "9600n8". drivers/tty/serial/8250/8250_early.c:early_serial8250_setup still have calling to probe_baud, but it is

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Wed, Apr 1, 2015 at 8:22 PM, Peter Hurley pe...@hurleysoftware.com wrote: The documented behavior of console=ttyS options, to which your quote refers, clearly states: Default is 9600n8. drivers/tty/serial/8250/8250_early.c:early_serial8250_setup still have calling to

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley pe...@hurleysoftware.com wrote: Would you please try the patch below instead? Great. that works, and less lines change than my version. still have another problem. when using

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 5:02 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 3:36 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 3:12 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2,

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 5:22 PM, Yinghai Lu ying...@kernel.org wrote: still have another problem. when using console=uart8250,io,0x3f8 it works as earlycon at first. but after handover to normal console it will revert back to 9600 again. this regression should be caused by: commit

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 3:12 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley pe...@hurleysoftware.com wrote: Would you please try the patch below instead? Great. that works, and less

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 3:36 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 3:12 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 10:23 AM, Yinghai Lu ying...@kernel.org wrote: On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley pe...@hurleysoftware.com wrote: Would

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Peter Hurley
Hi Yinghai, On 04/02/2015 05:15 AM, Yinghai Lu wrote: On Wed, Apr 1, 2015 at 8:22 PM, Peter Hurley pe...@hurleysoftware.com wrote: The documented behavior of console=ttyS options, to which your quote refers, clearly states: Default is 9600n8.

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-02 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley pe...@hurleysoftware.com wrote: Would you please try the patch below instead? --- % --- From: Peter Hurley pe...@hurleysoftware.com Subject: [PATCH] earlycon: Fix __earlycon_table stride Signed-off-by: Peter Hurley pe...@hurleysoftware.com ---

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-01 Thread Peter Hurley
Hi Yinghai, On 04/01/2015 10:04 PM, Yinghai Lu wrote: > On Mon, Mar 9, 2015 at 1:27 PM, Peter Hurley wrote: >> setup_earlycon() will now match and register the desired earlycon >> from the param string (as if 'earlycon=...' had been set on the >> command line). Use setup_earlycon() from existing

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-01 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 1:27 PM, Peter Hurley wrote: > setup_earlycon() will now match and register the desired earlycon > from the param string (as if 'earlycon=...' had been set on the > command line). Use setup_earlycon() from existing arch call sites > which start an earlycon directly. > Hi,

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-01 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 1:27 PM, Peter Hurley pe...@hurleysoftware.com wrote: setup_earlycon() will now match and register the desired earlycon from the param string (as if 'earlycon=...' had been set on the command line). Use setup_earlycon() from existing arch call sites which start an

Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-04-01 Thread Peter Hurley
Hi Yinghai, On 04/01/2015 10:04 PM, Yinghai Lu wrote: On Mon, Mar 9, 2015 at 1:27 PM, Peter Hurley pe...@hurleysoftware.com wrote: setup_earlycon() will now match and register the desired earlycon from the param string (as if 'earlycon=...' had been set on the command line). Use

[PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-03-09 Thread Peter Hurley
setup_earlycon() will now match and register the desired earlycon from the param string (as if 'earlycon=...' had been set on the command line). Use setup_earlycon() from existing arch call sites which start an earlycon directly. Acked-by: Rob Herring Signed-off-by: Peter Hurley ---

[PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-03-09 Thread Peter Hurley
setup_earlycon() will now match and register the desired earlycon from the param string (as if 'earlycon=...' had been set on the command line). Use setup_earlycon() from existing arch call sites which start an earlycon directly. Acked-by: Rob Herring r...@kernel.org Signed-off-by: Peter Hurley