This is v3 of the Theobroma Systems CAN/USB adapter driver
upstreaming effort.
Featured v2 -> v3 changes:
* count error frames as data packets
* use canid_t for all can ids
* use BIT(x) instead of (1 << x)
* use __le16 / __le32 for little-endian fields
* add spinlock around context allocation (fix
Where possible we changed dev_XXX to netdev_XXX. and removed all __func__.
netdev_XXX prints the necessary information on the device, bus and netif
The remaining dev_XXX (within probe) are extended such that they print
the string "ucan" (__func__ are also removed)
Am 23.03.18 um 11:12 schrieb Jako
Hello Jacob,
Am 22.03.2018 um 14:53 schrieb Jakob Unterwurzacher:
> This is v3 of the Theobroma Systems CAN/USB adapter driver
> upstreaming effort.
>
> Featured v2 -> v3 changes:
> * count error frames as data packets
> * use canid_t for all can ids
> * use BIT(x) instead of (1 << x)
> * use __l
On 23.03.18 09:32, Wolfgang Grandegger wrote:
* add __func__ to all errors and warnings, and to info where it made sense
The final output messages in the driver should especially be useful for
the end user... and not the developer! This is also true for the
function names. You already use more
Am 23.03.2018 um 10:40 schrieb Jakob Unterwurzacher:
> On 23.03.18 09:32, Wolfgang Grandegger wrote:
>>> * add __func__ to all errors and warnings, and to info where it made
>>> sense
>>
>> The final output messages in the driver should especially be useful for
>> the end user... and not the deve
On 23.03.18 11:04, Wolfgang Grandegger wrote:
But I'm open to other suggestions (use a fixed "ucan: " prefix?) or to
drop it entirely if you think it is not worth it.
But there is already a device prefix, e.g.:
peak_usb 1-6:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial (1
ch
6 matches
Mail list logo