Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Wolfram Sang
> I think the quirks can describe our HW limitation without issue. > We are porting our i2c driver base on that. Will let you know the test > result. Great news, thanks for the update :) signature.asc Description: Digital signature

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 10:57 +0100, Wolfram Sang wrote: > On Tue, Jan 06, 2015 at 02:37:53PM +0100, Wolfram Sang wrote: > > > > > We've started upstream work for MT8173[1]. > > > > > > We've fixed these issues for new SoC, and we believe it is fully I2C > > > compatible now. We'll add mt8173

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Wolfram Sang
On Tue, Jan 06, 2015 at 02:37:53PM +0100, Wolfram Sang wrote: > > > We've started upstream work for MT8173[1]. > > > > We've fixed these issues for new SoC, and we believe it is fully I2C > > compatible now. We'll add mt8173 support to this driver, so this driver > > will support both fully I2C

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Wolfram Sang
On Tue, Jan 06, 2015 at 02:37:53PM +0100, Wolfram Sang wrote: We've started upstream work for MT8173[1]. We've fixed these issues for new SoC, and we believe it is fully I2C compatible now. We'll add mt8173 support to this driver, so this driver will support both fully I2C compatible

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 10:57 +0100, Wolfram Sang wrote: On Tue, Jan 06, 2015 at 02:37:53PM +0100, Wolfram Sang wrote: We've started upstream work for MT8173[1]. We've fixed these issues for new SoC, and we believe it is fully I2C compatible now. We'll add mt8173 support to this

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Wolfram Sang
I think the quirks can describe our HW limitation without issue. We are porting our i2c driver base on that. Will let you know the test result. Great news, thanks for the update :) signature.asc Description: Digital signature

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-06 Thread Wolfram Sang
> We've started upstream work for MT8173[1]. > > We've fixed these issues for new SoC, and we believe it is fully I2C > compatible now. We'll add mt8173 support to this driver, so this driver > will support both fully I2C compatible SoC and the current one. From what you tell, I'd rather add

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-06 Thread Wolfram Sang
We've started upstream work for MT8173[1]. We've fixed these issues for new SoC, and we believe it is fully I2C compatible now. We'll add mt8173 support to this driver, so this driver will support both fully I2C compatible SoC and the current one. From what you tell, I'd rather add the

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-12-11 Thread Yingjoe Chen
On Thu, 2014-11-27 at 17:45 +0100, Wolfram Sang wrote: > > > I think there are now 3 drivers in my queue which are not fully I2C > > > compatible but more supporting the very minimum to, say, read an eeprom. > > > I am not feeling well to allow them to use I2C_FUNC_I2C. So, I want to > > > think

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-12-11 Thread Yingjoe Chen
On Thu, 2014-11-27 at 17:45 +0100, Wolfram Sang wrote: I think there are now 3 drivers in my queue which are not fully I2C compatible but more supporting the very minimum to, say, read an eeprom. I am not feeling well to allow them to use I2C_FUNC_I2C. So, I want to think about ways

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-27 Thread Wolfram Sang
> > I think there are now 3 drivers in my queue which are not fully I2C > > compatible but more supporting the very minimum to, say, read an eeprom. > > I am not feeling well to allow them to use I2C_FUNC_I2C. So, I want to > > think about ways how to communicate deficiencies like "only 255 byte"

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-27 Thread Yingjoe Chen
Hi, On Mon, 2014-11-24 at 13:15 +0100, Wolfram Sang wrote: > Hi, > > some very high level remarks: > > On Mon, Nov 24, 2014 at 05:38:46PM +0800, Xudong Chen wrote: > > This series is the third version of Mediatek SoCs I2C controller common > > bus driver. > > Compared to the second version, >

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-27 Thread Yingjoe Chen
Hi, On Mon, 2014-11-24 at 13:15 +0100, Wolfram Sang wrote: Hi, some very high level remarks: On Mon, Nov 24, 2014 at 05:38:46PM +0800, Xudong Chen wrote: This series is the third version of Mediatek SoCs I2C controller common bus driver. Compared to the second version, 1. Add

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-27 Thread Wolfram Sang
I think there are now 3 drivers in my queue which are not fully I2C compatible but more supporting the very minimum to, say, read an eeprom. I am not feeling well to allow them to use I2C_FUNC_I2C. So, I want to think about ways how to communicate deficiencies like only 255 byte or only

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-24 Thread Wolfram Sang
Hi, some very high level remarks: On Mon, Nov 24, 2014 at 05:38:46PM +0800, Xudong Chen wrote: > This series is the third version of Mediatek SoCs I2C controller common > bus driver. > Compared to the second version, > 1. Add comments for clock in dt-bindings file i2c-mt6577.txt. > 2. Remove

[PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-24 Thread Xudong Chen
This series is the third version of Mediatek SoCs I2C controller common bus driver. Compared to the second version, 1. Add comments for clock in dt-bindings file i2c-mt6577.txt. 2. Remove mt8135.dtsi because of the dependency on pinctrl and clock. 3. Encode the feature have-dcm in i2c-mt65xx.c by

[PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-24 Thread Xudong Chen
This series is the third version of Mediatek SoCs I2C controller common bus driver. Compared to the second version, 1. Add comments for clock in dt-bindings file i2c-mt6577.txt. 2. Remove mt8135.dtsi because of the dependency on pinctrl and clock. 3. Encode the feature have-dcm in i2c-mt65xx.c by

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-24 Thread Wolfram Sang
Hi, some very high level remarks: On Mon, Nov 24, 2014 at 05:38:46PM +0800, Xudong Chen wrote: This series is the third version of Mediatek SoCs I2C controller common bus driver. Compared to the second version, 1. Add comments for clock in dt-bindings file i2c-mt6577.txt. 2. Remove