Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

2014-04-23 Thread Dan Carpenter
On Wed, Apr 23, 2014 at 12:05:57PM +0300, Dan Carpenter wrote: > On Wed, Apr 23, 2014 at 04:49:26PM +0800, Michalis Pappas wrote: > > Hi Dan, thanks for looking at this. From the above snippet I realize > > that I wasn't aware of the strict flag, so significantly less errors > > were produced. > >

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

2014-04-23 Thread Dan Carpenter
On Wed, Apr 23, 2014 at 04:49:26PM +0800, Michalis Pappas wrote: > Hi Dan, thanks for looking at this. From the above snippet I realize > that I wasn't aware of the strict flag, so significantly less errors > were produced. > > The issues I was referring to as pedantic are: > > WARNING: unchecked

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

2014-04-23 Thread Michalis Pappas
On 04/23/2014 04:04 PM, Dan Carpenter wrote: > On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote: >> After all patches have been applied, the only remaining issue on the >> TODO list is to conform to the coding standards. The remaining issues >> reported by checkpatch.pl are probably

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

2014-04-23 Thread Dan Carpenter
On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote: > After all patches have been applied, the only remaining issue on the > TODO list is to conform to the coding standards. The remaining issues > reported by checkpatch.pl are probably pedantic, so if agreed, that > task can be remove

[PATCH v3 0/3] staging: gdm72xx: Minor cleanup

2014-04-22 Thread Michalis Pappas
The following patches perform various cleanups on the gdm72xx driver. PATCH 1/3 fixes some small coding style issues PATCH 2/3 removes an already completed item from the TODO list PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions After all patches have been applied, the only re