Re: [PATCH v3 0/5] perf report: Show inline stack

2017-03-02 Thread Jin, Yao
Hi Wolff, Thanks so much for your testing. I also wish this feature could be upstreamed. I will send a v4 series soon. In v4, It removes the options "--inline-line" and "--inline-name". It just uses a new option "--inline" to print the inline function information. The policy is if the inli

Re: [PATCH v3 0/5] perf report: Show inline stack

2017-03-02 Thread Milian Wolff
On Dienstag, 21. Februar 2017 01:28:17 CET Jin, Yao wrote: > Hi, > > Any comments for this patch series? Sorry for the delay. I just tested it again. Overall, this is a clear improvement, so I'm all for getting this functionality in. But from a usability point of view, I still have the some of

Re: [PATCH v3 0/5] perf report: Show inline stack

2017-02-20 Thread Jin, Yao
Hi, Any comments for this patch series? Thanks Jin Yao On 1/20/2017 5:39 PM, Jin Yao wrote: v3: Iterate on RIPs of all callchain entries to check if the RIP is in inline functions. Reverse the order of the inliner printout if necessary. Provide new options "--inline-line" /

[PATCH v3 0/5] perf report: Show inline stack

2017-01-19 Thread Jin Yao
v3: Iterate on RIPs of all callchain entries to check if the RIP is in inline functions. Reverse the order of the inliner printout if necessary. Provide new options "--inline-line" / "--inline-name" to print inline function name or print inline function source line. v2: Thanks so