Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-08 Thread Ackerley Tng
Christian Brauner writes: > On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: > > > > Fwiw, b4 allows to specify dependencies so you can b4 shazam/am and it > will pull in all prerequisite patches: > > b4 prep --edit-deps Edit the series dependencies in your defined >

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-08 Thread Christian Brauner
On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: > On 07.04.25 16:24, Liam R. Howlett wrote: > > * Nikita Kalyazin [250407 10:05]: > > > > > > > ... > > > > > > > > > > All of this is extremely confusing because the onus of figuring out what > > > > the final code will look l

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread David Hildenbrand
On 07.04.25 17:14, Lorenzo Stoakes wrote: On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: On 07.04.25 16:24, Liam R. Howlett wrote: * Nikita Kalyazin [250407 10:05]: ... All of this is extremely confusing because the onus of figuring out what the final code will look

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Lorenzo Stoakes
On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: > On 07.04.25 16:24, Liam R. Howlett wrote: > > * Nikita Kalyazin [250407 10:05]: > > > > > > > ... > > > > > > > > > > All of this is extremely confusing because the onus of figuring out what > > > > the final code will look like

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Liam R. Howlett
* Nikita Kalyazin [250407 10:05]: > ... > > > > All of this is extremely confusing because the onus of figuring out what > > the final code will look like is put on the reviewer. As it is, we have > > issues with people not doing enough review of the code (due to limited > > time). One way t

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread David Hildenbrand
On 07.04.25 16:24, Liam R. Howlett wrote: * Nikita Kalyazin [250407 10:05]: ... All of this is extremely confusing because the onus of figuring out what the final code will look like is put on the reviewer. As it is, we have issues with people not doing enough review of the code (due to

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Nikita Kalyazin
On 07/04/2025 14:40, Liam R. Howlett wrote: * Nikita Kalyazin [250407 07:04]: On 04/04/2025 18:12, Liam R. Howlett wrote: +To authors of v7 series referenced in [1] * Nikita Kalyazin [250404 11:44]: This series is built on top of the Fuad's v7 "mapping guest_memfd backed memory at the

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Liam R. Howlett
* Nikita Kalyazin [250407 07:04]: > > > On 04/04/2025 18:12, Liam R. Howlett wrote: > > +To authors of v7 series referenced in [1] > > > > * Nikita Kalyazin [250404 11:44]: > > > This series is built on top of the Fuad's v7 "mapping guest_memfd backed > > > memory at the host" [1]. > > > > I

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Nikita Kalyazin
On 04/04/2025 18:12, Liam R. Howlett wrote: +To authors of v7 series referenced in [1] * Nikita Kalyazin [250404 11:44]: This series is built on top of the Fuad's v7 "mapping guest_memfd backed memory at the host" [1]. I didn't see their addresses in the to/cc, so I added them to my respo

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-04 Thread Liam R. Howlett
+To authors of v7 series referenced in [1] * Nikita Kalyazin [250404 11:44]: > This series is built on top of the Fuad's v7 "mapping guest_memfd backed > memory at the host" [1]. I didn't see their addresses in the to/cc, so I added them to my response as I reference the v7 patch set below. >

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-04 Thread Lorenzo Stoakes
On Fri, Apr 04, 2025 at 05:56:58PM +0100, Nikita Kalyazin wrote: > > > On 04/04/2025 17:33, Lorenzo Stoakes wrote: > > On Fri, Apr 04, 2025 at 03:43:46PM +, Nikita Kalyazin wrote: > > > This series is built on top of the Fuad's v7 "mapping guest_memfd backed > > > memory at the host" [1]. > > >

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-04 Thread Nikita Kalyazin
On 04/04/2025 17:33, Lorenzo Stoakes wrote: On Fri, Apr 04, 2025 at 03:43:46PM +, Nikita Kalyazin wrote: This series is built on top of the Fuad's v7 "mapping guest_memfd backed memory at the host" [1]. Hm if this is based on an unmerged series this seems quite speculative and should ma

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-04 Thread Lorenzo Stoakes
On Fri, Apr 04, 2025 at 03:43:46PM +, Nikita Kalyazin wrote: > This series is built on top of the Fuad's v7 "mapping guest_memfd backed > memory at the host" [1]. Hm if this is based on an unmerged series this seems quite speculative and should maybe be an RFC? I mean that series at least stil

[PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-04 Thread Nikita Kalyazin
This series is built on top of the Fuad's v7 "mapping guest_memfd backed memory at the host" [1]. With James's KVM userfault [2], it is possible to handle stage-2 faults in guest_memfd in userspace. However, KVM itself also triggers faults in guest_memfd in some cases, for example: PV interfaces