Re: [PATCH v3 01/10] dmaengine: Actions: get rid of bit fields from dma descriptor

2020-06-03 Thread Amit Tomer
Hi, Thanks for having a look. On Wed, Jun 3, 2020 at 12:52 PM Manivannan Sadhasivam wrote: > Individual comments for these enums? I was expecting this comment , and thought these fields are self explanatory But if you prefer to have description about it, I would have it in next version. >

Re: [PATCH v3 01/10] dmaengine: Actions: get rid of bit fields from dma descriptor

2020-06-03 Thread Manivannan Sadhasivam
On 2 June 2020 11:03:03 PM IST, Amit Singh Tomar wrote: >At the moment, Driver uses bit fields to describe registers of the DMA >descriptor structure that makes it less portable and maintainable, and >Andre suugested(and even sketched important bits for it) to make use of >array to describe

[PATCH v3 01/10] dmaengine: Actions: get rid of bit fields from dma descriptor

2020-06-02 Thread Amit Singh Tomar
At the moment, Driver uses bit fields to describe registers of the DMA descriptor structure that makes it less portable and maintainable, and Andre suugested(and even sketched important bits for it) to make use of array to describe this DMA descriptors instead. It gives the flexibility while