Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

Hi Andrew, 在 2017/8/2 21:21, Andrew Lunn 写道: +static struct phy_driver rockchip_phy_driver[] = { +{ + .phy_id = 0x1234d400, + .phy_id_mask= 0xfff0, + .name = "Rockchip internal EPHY", + .features = (PHY_BASIC

Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

> +static struct phy_driver rockchip_phy_driver[] = { > +{ > + .phy_id = 0x1234d400, > + .phy_id_mask= 0xfff0, > + .name = "Rockchip internal EPHY", > + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause > +

Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

Hello I have some minor comment below > + > +#include > +#include > +#include > +#include > +#include > +#include in alphabetic order please [...] > +static int rockchip_init_tstmode(struct phy_device *phydev) > +{ > + int ret; > + > + /* Enable access to Analog and DSP register ba

[PATCH v3 01/11] net: phy: Add rockchip phy driver support

Support internal ethernet phy currently. Signed-off-by: David Wu --- drivers/net/phy/Kconfig| 5 + drivers/net/phy/Makefile | 1 + drivers/net/phy/rockchip.c | 229 + 3 files changed, 235 insertions(+) create mode 100644 drivers/net/phy/rock