Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Behan Webster
On 09/17/14 04:30, Herbert Xu wrote: On Wed, Sep 17, 2014 at 02:15:40PM +0300, Dmitry Kasatkin wrote: On 17/09/14 12:22, Herbert Xu wrote: On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: From: Behan Webster Add a macro which replaces the use of a Variable Length

Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Herbert Xu
On Wed, Sep 17, 2014 at 02:15:40PM +0300, Dmitry Kasatkin wrote: > On 17/09/14 12:22, Herbert Xu wrote: > > On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: > >> From: Behan Webster > >> > >> Add a macro which replaces the use of a Variable Length Array In Struct > >>

Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Dmitry Kasatkin
On 17/09/14 12:22, Herbert Xu wrote: > On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: >> From: Behan Webster >> >> Add a macro which replaces the use of a Variable Length Array In Struct >> (VLAIS) >> with a C99 compliant equivalent. This macro instead allocates the

Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Herbert Xu
On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: > From: Behan Webster > > Add a macro which replaces the use of a Variable Length Array In Struct > (VLAIS) > with a C99 compliant equivalent. This macro instead allocates the appropriate > amount of memory using an char

Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Herbert Xu
On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: From: Behan Webster beh...@converseincode.com Add a macro which replaces the use of a Variable Length Array In Struct (VLAIS) with a C99 compliant equivalent. This macro instead allocates the appropriate amount of

Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Dmitry Kasatkin
On 17/09/14 12:22, Herbert Xu wrote: On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: From: Behan Webster beh...@converseincode.com Add a macro which replaces the use of a Variable Length Array In Struct (VLAIS) with a C99 compliant equivalent. This macro instead

Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Herbert Xu
On Wed, Sep 17, 2014 at 02:15:40PM +0300, Dmitry Kasatkin wrote: On 17/09/14 12:22, Herbert Xu wrote: On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: From: Behan Webster beh...@converseincode.com Add a macro which replaces the use of a Variable Length Array In

Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-17 Thread Behan Webster
On 09/17/14 04:30, Herbert Xu wrote: On Wed, Sep 17, 2014 at 02:15:40PM +0300, Dmitry Kasatkin wrote: On 17/09/14 12:22, Herbert Xu wrote: On Mon, Sep 15, 2014 at 12:30:23AM -0700, beh...@converseincode.com wrote: From: Behan Webster beh...@converseincode.com Add a macro which replaces the

Re: [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-15 Thread Behan Webster
On 09/15/14 01:06, Michał Mirosław wrote: 2014-09-15 9:30 GMT+02:00 : [...] +#define SHASH_DESC_ON_STACK(shash, tfm) \ + char __desc[sizeof(struct shash_desc) + \ + crypto_shash_descsize(tfm)] CRYPTO_MINALIGN_ATTR; \ +

Re: [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-15 Thread Michał Mirosław
2014-09-15 9:30 GMT+02:00 : [...] > +#define SHASH_DESC_ON_STACK(shash, tfm) \ > + char __desc[sizeof(struct shash_desc) + \ > + crypto_shash_descsize(tfm)] CRYPTO_MINALIGN_ATTR; \ > + struct shash_desc *shash = (struct

[PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-15 Thread behanw
From: Behan Webster Add a macro which replaces the use of a Variable Length Array In Struct (VLAIS) with a C99 compliant equivalent. This macro instead allocates the appropriate amount of memory using an char array. The new code can be compiled with both gcc and clang. struct shash_desc

[PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-15 Thread behanw
From: Behan Webster beh...@converseincode.com Add a macro which replaces the use of a Variable Length Array In Struct (VLAIS) with a C99 compliant equivalent. This macro instead allocates the appropriate amount of memory using an char array. The new code can be compiled with both gcc and clang.

Re: [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-15 Thread Michał Mirosław
2014-09-15 9:30 GMT+02:00 beh...@converseincode.com: [...] +#define SHASH_DESC_ON_STACK(shash, tfm) \ + char __desc[sizeof(struct shash_desc) + \ + crypto_shash_descsize(tfm)] CRYPTO_MINALIGN_ATTR; \ + struct

Re: [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-15 Thread Behan Webster
On 09/15/14 01:06, Michał Mirosław wrote: 2014-09-15 9:30 GMT+02:00 beh...@converseincode.com: [...] +#define SHASH_DESC_ON_STACK(shash, tfm) \ + char __desc[sizeof(struct shash_desc) + \ + crypto_shash_descsize(tfm)]