Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-13 Thread Andy Shevchenko
On Wed, 2016-04-06 at 21:09 +, Koul, Vinod wrote: > On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: > > > > On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul > > wrote: > > > > > > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > > > > > > > > On

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-13 Thread Andy Shevchenko
On Wed, 2016-04-06 at 21:09 +, Koul, Vinod wrote: > On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: > > > > On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul > > wrote: > > > > > > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > > > > > > > > On Mon, 2016-04-04 at

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-07 Thread Andy Shevchenko
On Thu, Apr 7, 2016 at 12:09 AM, Koul, Vinod wrote: > On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: >> On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul >> wrote: >> > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: >> > > On Mon,

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-07 Thread Andy Shevchenko
On Thu, Apr 7, 2016 at 12:09 AM, Koul, Vinod wrote: > On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: >> On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul >> wrote: >> > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: >> > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: > On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul > wrote: > > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > > > > On Fri, Mar 18, 2016 at

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: > On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul > wrote: > > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > > > > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul wrote: > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: >> On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: >> > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: >> > > >> > > + /* >> > > + *

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul wrote: > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: >> On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: >> > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: >> > > >> > > + /* >> > > + * We need

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Vinod Koul
On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > > > > > > + /* > > > +  * We need controller-specific data to set up slave > > > transfers. > > > +  */ >

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Vinod Koul
On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > > > > > > + /* > > > +  * We need controller-specific data to set up slave > > > transfers. > > > +  */ >

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-04 Thread Andy Shevchenko
On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > > > > + /* > > +  * We need controller-specific data to set up slave > > transfers. > > +  */ > > + BUG_ON(chan->private && !dw_dma_filter(chan, chan- > > >private));

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-04 Thread Andy Shevchenko
On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > > > > + /* > > +  * We need controller-specific data to set up slave > > transfers. > > +  */ > > + BUG_ON(chan->private && !dw_dma_filter(chan, chan- > > >private));

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-04 Thread Vinod Koul
On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > + /* > + * We need controller-specific data to set up slave transfers. > + */ > + BUG_ON(chan->private && !dw_dma_filter(chan, chan->private)); I don't think BUG_ON is apt here, gracefully failing and printing

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-04 Thread Vinod Koul
On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > + /* > + * We need controller-specific data to set up slave transfers. > + */ > + BUG_ON(chan->private && !dw_dma_filter(chan, chan->private)); I don't think BUG_ON is apt here, gracefully failing and printing

[PATCH v3 01/15] dmaengine: dw: fix master selection

2016-03-18 Thread Andy Shevchenko
The commit 895005202987 ("dmaengine: dw: apply both HS interfaces and remove slave_id usage") cleaned up the code to avoid usage of depricated slave_id member of generic slave configuration. Meanwhile it broke the master selection by removing important call to dwc_set_masters() in

[PATCH v3 01/15] dmaengine: dw: fix master selection

2016-03-18 Thread Andy Shevchenko
The commit 895005202987 ("dmaengine: dw: apply both HS interfaces and remove slave_id usage") cleaned up the code to avoid usage of depricated slave_id member of generic slave configuration. Meanwhile it broke the master selection by removing important call to dwc_set_masters() in