Re: [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-11 Thread Sekhar Nori
On Monday 12 August 2013 09:59 AM, Joel Fernandes wrote: > On Sun, Aug 11, 2013 at 11:25 PM, Sekhar Nori wrote: >> On 8/8/2013 5:19 PM, Sekhar Nori wrote: >>> On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: We certainly don't want error conditions to be cleared any other place b

Re: [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-11 Thread Joel Fernandes
On Sun, Aug 11, 2013 at 11:25 PM, Sekhar Nori wrote: > On 8/8/2013 5:19 PM, Sekhar Nori wrote: >> On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: >>> We certainly don't want error conditions to be cleared any other >>> place but the EDMA error handler, as this will make us 'forget' >>> ab

Re: [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-11 Thread Sekhar Nori
On 8/8/2013 5:19 PM, Sekhar Nori wrote: > On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: >> We certainly don't want error conditions to be cleared any other >> place but the EDMA error handler, as this will make us 'forget' >> about missed events we might need to know errors have occurred

Re: [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-08 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > We certainly don't want error conditions to be cleared any other > place but the EDMA error handler, as this will make us 'forget' > about missed events we might need to know errors have occurred. > > This fixes a race condition where the

[PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-05 Thread Joel Fernandes
We certainly don't want error conditions to be cleared any other place but the EDMA error handler, as this will make us 'forget' about missed events we might need to know errors have occurred. This fixes a race condition where the EMR was being cleared by the transfer completion interrupt handler.