Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-07 Thread Thomas Petazzoni
Dear Andrew Lunn, On Wed, 7 May 2014 15:21:50 +0200, Andrew Lunn wrote: > > Thanks to devm_phy_optional_get(), the fact of not having a PHY in the > > DT is not considered an error. So on any error from > > devm_phy_optional_get() (including -EPROBE_DEFER), we simply bail out. > > Does this

Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-07 Thread Andrew Lunn
On Wed, May 07, 2014 at 11:40:06AM +0200, Thomas Petazzoni wrote: > Dear Andrew Lunn, > > On Tue, 6 May 2014 15:33:41 +0200, Andrew Lunn wrote: > > > > + priv->phy = devm_phy_get(>dev, "usb"); > > > + if (!IS_ERR(priv->phy)) { > > > + err = phy_init(priv->phy); > > > + if (err) >

Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-07 Thread Thomas Petazzoni
Dear Andrew Lunn, On Tue, 6 May 2014 15:33:41 +0200, Andrew Lunn wrote: > > + priv->phy = devm_phy_get(>dev, "usb"); > > + if (!IS_ERR(priv->phy)) { > > + err = phy_init(priv->phy); > > + if (err) > > + goto err2; > > + > > + err =

Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-07 Thread Thomas Petazzoni
Dear Andrew Lunn, On Tue, 6 May 2014 15:33:41 +0200, Andrew Lunn wrote: + priv-phy = devm_phy_get(pdev-dev, usb); + if (!IS_ERR(priv-phy)) { + err = phy_init(priv-phy); + if (err) + goto err2; + + err = phy_power_on(priv-phy); +

Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-07 Thread Andrew Lunn
On Wed, May 07, 2014 at 11:40:06AM +0200, Thomas Petazzoni wrote: Dear Andrew Lunn, On Tue, 6 May 2014 15:33:41 +0200, Andrew Lunn wrote: + priv-phy = devm_phy_get(pdev-dev, usb); + if (!IS_ERR(priv-phy)) { + err = phy_init(priv-phy); + if (err) +

Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-07 Thread Thomas Petazzoni
Dear Andrew Lunn, On Wed, 7 May 2014 15:21:50 +0200, Andrew Lunn wrote: Thanks to devm_phy_optional_get(), the fact of not having a PHY in the DT is not considered an error. So on any error from devm_phy_optional_get() (including -EPROBE_DEFER), we simply bail out. Does this looks good?

Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-06 Thread Andrew Lunn
On Tue, May 06, 2014 at 02:13:57AM +0200, Gregory CLEMENT wrote: > This commit allows to use the PHY provided through the device tree. It > will be useful for the Armada 375 SoCs. if no PHY is provided then the > behavior of the driver is unchanged. > > Signed-off-by: Gregory CLEMENT > --- >

Re: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-06 Thread Andrew Lunn
On Tue, May 06, 2014 at 02:13:57AM +0200, Gregory CLEMENT wrote: This commit allows to use the PHY provided through the device tree. It will be useful for the Armada 375 SoCs. if no PHY is provided then the behavior of the driver is unchanged. Signed-off-by: Gregory CLEMENT

[PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-05 Thread Gregory CLEMENT
This commit allows to use the PHY provided through the device tree. It will be useful for the Armada 375 SoCs. if no PHY is provided then the behavior of the driver is unchanged. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/ehci-orion.c | 25 +++-- 1 file changed, 23

[PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support

2014-05-05 Thread Gregory CLEMENT
This commit allows to use the PHY provided through the device tree. It will be useful for the Armada 375 SoCs. if no PHY is provided then the behavior of the driver is unchanged. Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com --- drivers/usb/host/ehci-orion.c | 25