Re: [PATCH v3 03/10] pci: drop some duplicate code

2015-03-24 Thread Michael S. Tsirkin
On Tue, Mar 24, 2015 at 06:33:57PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 24, 2015 at 04:42:35PM +0100, Michael S. Tsirkin wrote: > > pci_msi_init_pci_dev and pci_msi_off share a lot of code. > > This used to be justified since pci_msi_init_pci_dev > > wasn't compiled in when CONFIG_PCI_MSI is

Re: [PATCH v3 03/10] pci: drop some duplicate code

2015-03-24 Thread Bjorn Helgaas
On Tue, Mar 24, 2015 at 04:42:35PM +0100, Michael S. Tsirkin wrote: > pci_msi_init_pci_dev and pci_msi_off share a lot of code. > This used to be justified since pci_msi_init_pci_dev > wasn't compiled in when CONFIG_PCI_MSI is off. > Now that it is, let's reuse code. > > Signed-off-by: Michael S.

[PATCH v3 03/10] pci: drop some duplicate code

2015-03-24 Thread Michael S. Tsirkin
pci_msi_init_pci_dev and pci_msi_off share a lot of code. This used to be justified since pci_msi_init_pci_dev wasn't compiled in when CONFIG_PCI_MSI is off. Now that it is, let's reuse code. Signed-off-by: Michael S. Tsirkin --- drivers/pci/pci.c | 24 +---

Re: [PATCH v3 03/10] pci: drop some duplicate code

2015-03-24 Thread Bjorn Helgaas
On Tue, Mar 24, 2015 at 04:42:35PM +0100, Michael S. Tsirkin wrote: pci_msi_init_pci_dev and pci_msi_off share a lot of code. This used to be justified since pci_msi_init_pci_dev wasn't compiled in when CONFIG_PCI_MSI is off. Now that it is, let's reuse code. Signed-off-by: Michael S.

Re: [PATCH v3 03/10] pci: drop some duplicate code

2015-03-24 Thread Michael S. Tsirkin
On Tue, Mar 24, 2015 at 06:33:57PM -0500, Bjorn Helgaas wrote: On Tue, Mar 24, 2015 at 04:42:35PM +0100, Michael S. Tsirkin wrote: pci_msi_init_pci_dev and pci_msi_off share a lot of code. This used to be justified since pci_msi_init_pci_dev wasn't compiled in when CONFIG_PCI_MSI is off.

[PATCH v3 03/10] pci: drop some duplicate code

2015-03-24 Thread Michael S. Tsirkin
pci_msi_init_pci_dev and pci_msi_off share a lot of code. This used to be justified since pci_msi_init_pci_dev wasn't compiled in when CONFIG_PCI_MSI is off. Now that it is, let's reuse code. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/pci/pci.c | 24 +---