Re: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic intercepts

2020-07-30 Thread Paolo Bonzini
On 31/07/20 00:41, Babu Moger wrote: >> Let me try to understand. >> >> vmcb01 is &svm->vmcb->control;l >> vmcb02 is &svm->nested.hsave->control >> vmcb12 is &svm->nested.ctl; Right now we don't have a separate vmcb01/vmcb02, we have the current and hsave VMCBs. Cathy is working on it. Just do

RE: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic intercepts

2020-07-30 Thread Babu Moger
he arch/x86 maintainers ; LKML > ; Ingo Molnar ; Borislav > Petkov ; H . Peter Anvin ; Thomas Gleixner > > Subject: RE: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic > intercepts > > > > > -Original Message- > > From: Paolo Bonzini > >

RE: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic intercepts

2020-07-30 Thread Babu Moger
Molnar ; Borislav > Petkov ; H . Peter Anvin ; Thomas Gleixner > > Subject: Re: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic > intercepts > > On 29/07/20 01:59, Jim Mattson wrote: > >> case SVM_EXIT_READ_DR0 ... SVM_EXIT_WRITE_DR7: { > >&

Re: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic intercepts

2020-07-29 Thread Paolo Bonzini
On 29/07/20 01:59, Jim Mattson wrote: >> case SVM_EXIT_READ_DR0 ... SVM_EXIT_WRITE_DR7: { >> - u32 bit = 1U << (exit_code - SVM_EXIT_READ_DR0); >> - if (svm->nested.ctl.intercept_dr & bit) >> + if (__is_intercept(&svm->nested.ctl.intercepts, exit_co

RE: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic intercepts

2020-07-29 Thread Babu Moger
; Borislav Petkov ; H . Peter Anvin > ; Thomas Gleixner > Subject: Re: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic > intercepts > > On Tue, Jul 28, 2020 at 4:38 PM Babu Moger wrote: > > > > Modify intercept_dr to generic intercepts in vmcb_control_a

Re: [PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic intercepts

2020-07-28 Thread Jim Mattson
On Tue, Jul 28, 2020 at 4:38 PM Babu Moger wrote: > > Modify intercept_dr to generic intercepts in vmcb_control_area. > Use generic __set_intercept, __clr_intercept and __is_intercept > to set/clear/test the intercept_dr bits. > > Signed-off-by: Babu Moger > --- > arch/x86/include/asm/svm.h |

[PATCH v3 03/11] KVM: SVM: Change intercept_dr to generic intercepts

2020-07-28 Thread Babu Moger
Modify intercept_dr to generic intercepts in vmcb_control_area. Use generic __set_intercept, __clr_intercept and __is_intercept to set/clear/test the intercept_dr bits. Signed-off-by: Babu Moger --- arch/x86/include/asm/svm.h | 36 ++-- arch/x86/kvm/svm/nested.c