Re: [PATCH v3 03/14] drm/sun4i: tcon: Add variant callback for TCON output muxing

2017-10-02 Thread Chen-Yu Tsai
On Fri, Sep 29, 2017 at 6:19 PM, Maxime Ripard wrote: > On Fri, Sep 29, 2017 at 08:22:55AM +, Chen-Yu Tsai wrote: >> static const struct sun4i_tcon_quirks sun5i_a13_quirks = { >> - .has_unknown_mux = true, >> - .has_channel_1 = true, >> +

Re: [PATCH v3 03/14] drm/sun4i: tcon: Add variant callback for TCON output muxing

2017-10-02 Thread Chen-Yu Tsai
On Fri, Sep 29, 2017 at 6:19 PM, Maxime Ripard wrote: > On Fri, Sep 29, 2017 at 08:22:55AM +, Chen-Yu Tsai wrote: >> static const struct sun4i_tcon_quirks sun5i_a13_quirks = { >> - .has_unknown_mux = true, >> - .has_channel_1 = true, >> + .has_unknown_mux= true, >> +

Re: [PATCH v3 03/14] drm/sun4i: tcon: Add variant callback for TCON output muxing

2017-09-29 Thread Maxime Ripard
On Fri, Sep 29, 2017 at 08:22:55AM +, Chen-Yu Tsai wrote: > static const struct sun4i_tcon_quirks sun5i_a13_quirks = { > - .has_unknown_mux = true, > - .has_channel_1 = true, > + .has_unknown_mux= true, > + .has_channel_1 = true, > + .set_mux

Re: [PATCH v3 03/14] drm/sun4i: tcon: Add variant callback for TCON output muxing

2017-09-29 Thread Maxime Ripard
On Fri, Sep 29, 2017 at 08:22:55AM +, Chen-Yu Tsai wrote: > static const struct sun4i_tcon_quirks sun5i_a13_quirks = { > - .has_unknown_mux = true, > - .has_channel_1 = true, > + .has_unknown_mux= true, > + .has_channel_1 = true, > + .set_mux

[PATCH v3 03/14] drm/sun4i: tcon: Add variant callback for TCON output muxing

2017-09-29 Thread Chen-Yu Tsai
Different SoCs have different muxing options and values for the TCON outputs. Instead of stuffing every possibility in sun4i_tcon_set_mux(), add a callback pointer to sun4i_tcon_quirks that each TCON variant can use to provide muxing support. The current muxing options in sun4i_tcon_set_mux() for

[PATCH v3 03/14] drm/sun4i: tcon: Add variant callback for TCON output muxing

2017-09-29 Thread Chen-Yu Tsai
Different SoCs have different muxing options and values for the TCON outputs. Instead of stuffing every possibility in sun4i_tcon_set_mux(), add a callback pointer to sun4i_tcon_quirks that each TCON variant can use to provide muxing support. The current muxing options in sun4i_tcon_set_mux() for