Re: [PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function

2017-07-12 Thread Alan Tull
On Mon, Jul 10, 2017 at 12:36 PM, Moritz Fischer wrote: >> +struct fpga_image_info *fpga_image_info_alloc(struct device *dev) >> +{ >> + struct fpga_image_info *info; >> + >> + info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL); >> + if (!info) >> + return ERR_PTR

Re: [PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function

2017-07-10 Thread Alan Tull
On Mon, Jul 10, 2017 at 12:36 PM, Moritz Fischer wrote: Hi Moritz, Thanks for looking at this stuff. >> >> +struct fpga_image_info *fpga_image_info_alloc(struct device *dev) >> +{ >> + struct fpga_image_info *info; >> + >> + info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL); >> +

Re: [PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function

2017-07-10 Thread Moritz Fischer
Hi Alan, On Thu, Jul 6, 2017 at 11:47 AM, Alan Tull wrote: > fpga-mgr has three methods for programming FPGAs, depending on > whether the image is in a scatter gather list, a contiguous > buffer, or a firmware file. This makes it difficult to write > upper layers as the caller has to assume wheth

[PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function

2017-07-06 Thread Alan Tull
fpga-mgr has three methods for programming FPGAs, depending on whether the image is in a scatter gather list, a contiguous buffer, or a firmware file. This makes it difficult to write upper layers as the caller has to assume whether the FPGA image is in a sg table, as a single buffer, or a firmware