Re: [PATCH v3 03/18] nitro_enclaves: Define enclave info for internal bookkeeping

2020-05-26 Thread Paraschiv, Andra-Irina
On 26/05/2020 09:46, Greg KH wrote: On Tue, May 26, 2020 at 01:13:19AM +0300, Andra Paraschiv wrote: +/* Nitro Enclaves (NE) misc device */ +extern struct miscdevice ne_miscdevice; Why does your misc device need to be in a .h file? Having the patch series like this (add random .h files, and

Re: [PATCH v3 03/18] nitro_enclaves: Define enclave info for internal bookkeeping

2020-05-26 Thread Greg KH
On Tue, May 26, 2020 at 01:13:19AM +0300, Andra Paraschiv wrote: > +/* Nitro Enclaves (NE) misc device */ > +extern struct miscdevice ne_miscdevice; Why does your misc device need to be in a .h file? Having the patch series like this (add random .h files, and then start to use them), is hard to

[PATCH v3 03/18] nitro_enclaves: Define enclave info for internal bookkeeping

2020-05-25 Thread Andra Paraschiv
The Nitro Enclaves driver keeps an internal info per each enclave. This is needed to be able to manage enclave resources state, enclave notifications and have a reference of the PCI device that handles command requests for enclave lifetime management. Signed-off-by: Alexandru-Catalin Vasile