Re: [PATCH v3 04/11] PCI/MSI/pSeries: Make quota traversing and requesting race-safe

2013-12-13 Thread Alexander Gordeev
On Tue, Dec 10, 2013 at 03:30:20PM -0700, Bjorn Helgaas wrote: > Can you outline the race and the scenario that leads to incorrect results > or a crash? I looked through rtas_setup_msi_irqs() (briefly) and I didn't > see the way that concurrent calls for different devices could interfere > with ea

Re: [PATCH v3 04/11] PCI/MSI/pSeries: Make quota traversing and requesting race-safe

2013-12-10 Thread Bjorn Helgaas
On Tue, Nov 26, 2013 at 10:09:53AM +0100, Alexander Gordeev wrote: > The current MSI quota handling is not race-safe and might lead > to incoherent number of MSIs allocated between the firmware and > Linux MSI data structures. I.e. if the following chain is called > from concurrently loading driver

[PATCH v3 04/11] PCI/MSI/pSeries: Make quota traversing and requesting race-safe

2013-11-26 Thread Alexander Gordeev
The current MSI quota handling is not race-safe and might lead to incoherent number of MSIs allocated between the firmware and Linux MSI data structures. I.e. if the following chain is called from concurrently loading drivers: rtas_setup_msi_irqs() -> msi_quota_for_device() -> traverse_pci_devices(