Re: [PATCH v3 04/12] clk: Add regmap core helpers for enable/disable/is_enabled

2013-12-24 Thread Gerhard Sittig
On Thu, Dec 19, 2013 at 21:24 +0100, Gerhard Sittig wrote: > > Wasn't the idea to extend the set of register accessor routines > in such that memory mapped I/O as well as > regmap style becomes possible? This is what I understood from > past iterations of discussing this approach. Just FYI and

Re: [PATCH v3 04/12] clk: Add regmap core helpers for enable/disable/is_enabled

2013-12-20 Thread Stephen Boyd
On 12/18, Mike Turquette wrote: > Quoting Stephen Boyd (2013-10-16 00:40:06) > > struct clk_hw { > > struct clk *clk; > > const struct clk_init_data *init; > > struct regmap *regmap; > > + unsigned int enable_reg; > > + unsigned int enable_mask; > > + bool

Re: [PATCH v3 04/12] clk: Add regmap core helpers for enable/disable/is_enabled

2013-12-19 Thread Gerhard Sittig
On Wed, Dec 18, 2013 at 20:50 -0800, Mike Turquette wrote: > > Adding all of this stuff to struct clk_hw makes me a sad panda. You are > essentially sharing a common set of ops for clocks that use regmap as > their io operation back-end, and that is a good thing. > > However, why not just do this

[PATCH v3 04/12] clk: Add regmap core helpers for enable/disable/is_enabled

2013-10-16 Thread Stephen Boyd
The clock framework already has support for simple gate clocks but if drivers want to use the gate clock functionality they need to wrap the gate clock in another struct and chain the ops by calling the gate ops from their own custom ops. Plus the gate clock implementation only supports MMIO access