Re: [PATCH v3 04/15] phy: tegra: xusb: tegra210: Do not reset UPHY PLL

2020-10-13 Thread JC Kuo
Asserting reset to a PLL when it's managed by hardware power sequencer would break sequencer's state machine. Putting PLL in reset doesn't save some extra power. Thanks for review. JC On 9/28/20 9:06 PM, Thierry Reding wrote: > On Wed, Sep 09, 2020 at 04:10:30PM +0800, JC Kuo wrote: >> Once

Re: [PATCH v3 04/15] phy: tegra: xusb: tegra210: Do not reset UPHY PLL

2020-09-28 Thread Thierry Reding
On Wed, Sep 09, 2020 at 04:10:30PM +0800, JC Kuo wrote: > Once UPHY PLL hardware power sequencer is enabled, do not assert > reset to PEX/SATA PLLs, otherwise UPHY PLL operation will be broken. > This commit removes reset_control_assert(pcie->rst) and > reset_control_assert(sata->rst) from

[PATCH v3 04/15] phy: tegra: xusb: tegra210: Do not reset UPHY PLL

2020-09-09 Thread JC Kuo
Once UPHY PLL hardware power sequencer is enabled, do not assert reset to PEX/SATA PLLs, otherwise UPHY PLL operation will be broken. This commit removes reset_control_assert(pcie->rst) and reset_control_assert(sata->rst) from PEX/SATA UPHY disable procedure. Signed-off-by: JC Kuo --- v3: