Re: [PATCH v3 04/21] fpga: add device feature list support

2018-01-31 Thread Alan Tull
On Fri, Dec 22, 2017 at 2:45 AM, Wu Hao wrote: >> > > >> > > I see that the port code is included as part of the enumeration code. >> > > This is not very future-proofed, if a different port needs to be >> > > supported. >> > > >> > > The port is a FPGA fabric based bridge with expanded functiona

Re: [PATCH v3 04/21] fpga: add device feature list support

2017-12-22 Thread Wu Hao
On Thu, Dec 21, 2017 at 03:22:42PM +0800, Wu Hao wrote: > On Wed, Dec 20, 2017 at 06:58:01PM -0600, Alan Tull wrote: > > On Wed, Dec 20, 2017 at 4:29 PM, Alan Tull wrote: > > > On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao wrote: > > > > > > Hi Hao, > > > > > >> + > > >> +enum port_feature_id { > > >>

Re: [PATCH v3 04/21] fpga: add device feature list support

2017-12-20 Thread Wu Hao
On Wed, Dec 20, 2017 at 06:58:01PM -0600, Alan Tull wrote: > On Wed, Dec 20, 2017 at 4:29 PM, Alan Tull wrote: > > On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao wrote: > > > > Hi Hao, > > > >> + > >> +enum port_feature_id { > >> + PORT_FEATURE_ID_HEADER = 0x0, > >> + PORT_FEATURE_ID_ERROR

Re: [PATCH v3 04/21] fpga: add device feature list support

2017-12-20 Thread Alan Tull
On Wed, Dec 20, 2017 at 4:29 PM, Alan Tull wrote: > On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao wrote: > > Hi Hao, > >> + >> +enum port_feature_id { >> + PORT_FEATURE_ID_HEADER = 0x0, >> + PORT_FEATURE_ID_ERROR = 0x1, >> + PORT_FEATURE_ID_UMSG = 0x2, >> + PORT_FEATURE_ID_PR =

Re: [PATCH v3 04/21] fpga: add device feature list support

2017-12-20 Thread Alan Tull
On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao wrote: Hi Hao, > + > +enum port_feature_id { > + PORT_FEATURE_ID_HEADER = 0x0, > + PORT_FEATURE_ID_ERROR = 0x1, > + PORT_FEATURE_ID_UMSG = 0x2, > + PORT_FEATURE_ID_PR = 0x3, > + PORT_FEATURE_ID_STP = 0x4, > + PORT_FEATU

Re: [PATCH v3 04/21] fpga: add device feature list support

2017-11-29 Thread Wu Hao
On Tue, Nov 28, 2017 at 10:07:36PM -0800, Moritz Fischer wrote: > Hi Hao, > > first pass, I didn't get all the way through, yet. Hi Moritz Thanks a lot for your review and comments. :) > > On Mon, Nov 27, 2017 at 02:42:11PM +0800, Wu Hao wrote: > > Device Feature List (DFL) defines a feature l

Re: [PATCH v3 04/21] fpga: add device feature list support

2017-11-28 Thread Moritz Fischer
Hi Hao, first pass, I didn't get all the way through, yet. On Mon, Nov 27, 2017 at 02:42:11PM +0800, Wu Hao wrote: > Device Feature List (DFL) defines a feature list structure that creates > a link list of feature headers within the MMIO space to provide an > extensible way of adding features. Th

[PATCH v3 04/21] fpga: add device feature list support

2017-11-26 Thread Wu Hao
Device Feature List (DFL) defines a feature list structure that creates a link list of feature headers within the MMIO space to provide an extensible way of adding features. This patch introduces a kernel module to provide basic infrastructure to support FPGA devices which implement the Device Feat