Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-08-08 Thread Vinod Koul
On 15-07-19, 11:17, Fuqian Huang wrote: > In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. Applied, thanks -- ~Vinod

Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-07-16 Thread Sinan Kaya
On 7/16/2019 7:35 AM, Robin Murphy wrote: > On 15/07/2019 16:17, Sinan Kaya wrote: >> On 7/15/2019 1:43 AM, Fuqian Huang wrote: >>> Should I rewrite the commit log? Just mention that dma_alloc_coherent >>> has already >>> zeroed the memory and not to reference the commit? >> >> I'd like to hear

Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-07-16 Thread Robin Murphy
On 15/07/2019 16:17, Sinan Kaya wrote: On 7/15/2019 1:43 AM, Fuqian Huang wrote: Should I rewrite the commit log? Just mention that dma_alloc_coherent has already zeroed the memory and not to reference the commit? I'd like to hear from Robin Murphy that arm smmu driver follows this as well.

Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-07-15 Thread Sinan Kaya
On 7/15/2019 1:43 AM, Fuqian Huang wrote: > Should I rewrite the commit log? Just mention that dma_alloc_coherent > has already > zeroed the memory and not to reference the commit? I'd like to hear from Robin Murphy that arm smmu driver follows this as well.

Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-07-14 Thread Fuqian Huang
Sinan Kaya 於 2019年7月15日週一 下午12:17寫道: > > On 7/14/2019 11:17 PM, Fuqian Huang wrote: > > In commit 518a2f1925c3 > > ("dma-mapping: zero memory returned from dma_alloc_*"), > > dma_alloc_coherent has already zeroed the memory. > > So memset is not needed. > > > > Signed-off-by: Fuqian Huang > > I

Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-07-14 Thread Sinan Kaya
On 7/14/2019 11:17 PM, Fuqian Huang wrote: > In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang I don't see SWIO or ARM64 IOMMU drivers getting impacted

[PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-07-14 Thread Fuqian Huang
In commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- Changes in v3: - Use actual commit rather than the merge commit in the commit message