Re: [PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-20 Thread Valentin Schneider
On 19/11/2018 17:31, Steven Sistare wrote: [...] >>> +#define IF_SMP(statement) statement >>> + >> >> I'm not too hot on those IF_SMP() macros. Since you're not introducing >> any other user for them, what about an inline function for rq->idle_stamp >> setting ? When it's mapped to an empty

Re: [PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-20 Thread Valentin Schneider
On 19/11/2018 17:31, Steven Sistare wrote: [...] >>> +#define IF_SMP(statement) statement >>> + >> >> I'm not too hot on those IF_SMP() macros. Since you're not introducing >> any other user for them, what about an inline function for rq->idle_stamp >> setting ? When it's mapped to an empty

Re: [PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-19 Thread Steven Sistare
On 11/9/2018 2:07 PM, Valentin Schneider wrote: > Hi Steve, > > On 09/11/2018 12:50, Steve Sistare wrote: >> Move the update of idle_stamp from idle_balance to the call site in >> pick_next_task_fair, to prepare for a future patch that adds work to >> pick_next_task_fair which must be included in

Re: [PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-19 Thread Steven Sistare
On 11/9/2018 2:07 PM, Valentin Schneider wrote: > Hi Steve, > > On 09/11/2018 12:50, Steve Sistare wrote: >> Move the update of idle_stamp from idle_balance to the call site in >> pick_next_task_fair, to prepare for a future patch that adds work to >> pick_next_task_fair which must be included in

Re: [PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-09 Thread Valentin Schneider
Hi Steve, On 09/11/2018 12:50, Steve Sistare wrote: > Move the update of idle_stamp from idle_balance to the call site in > pick_next_task_fair, to prepare for a future patch that adds work to > pick_next_task_fair which must be included in the idle_stamp interval. > No functional change. > >

Re: [PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-09 Thread Valentin Schneider
Hi Steve, On 09/11/2018 12:50, Steve Sistare wrote: > Move the update of idle_stamp from idle_balance to the call site in > pick_next_task_fair, to prepare for a future patch that adds work to > pick_next_task_fair which must be included in the idle_stamp interval. > No functional change. > >

[PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-09 Thread Steve Sistare
Move the update of idle_stamp from idle_balance to the call site in pick_next_task_fair, to prepare for a future patch that adds work to pick_next_task_fair which must be included in the idle_stamp interval. No functional change. Signed-off-by: Steve Sistare --- kernel/sched/fair.c | 23

[PATCH v3 05/10] sched/fair: Hoist idle_stamp up from idle_balance

2018-11-09 Thread Steve Sistare
Move the update of idle_stamp from idle_balance to the call site in pick_next_task_fair, to prepare for a future patch that adds work to pick_next_task_fair which must be included in the idle_stamp interval. No functional change. Signed-off-by: Steve Sistare --- kernel/sched/fair.c | 23