RE: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-03-16 Thread ruansy.f...@fujitsu.com
> -Original Message- > From: zhong jiang > Subject: Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for > dax mapping > > > +int mf_dax_mapping_kill_procs(struct address_space *mapping, pgoff_t > > +index, int flags) { > > +

Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-03-15 Thread zhong jiang
On 2021/2/8 6:55 下午, Shiyang Ruan wrote: The current memory_failure_dev_pagemap() can only handle single-mapped dax page for fsdax mode. The dax page could be mapped by multiple files and offsets if we let reflink feature & fsdax mode work together. So, we refactor current implementation to

Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-02-18 Thread Christoph Hellwig
On Wed, Feb 17, 2021 at 10:56:11AM +0800, Ruan Shiyang wrote: > I'd like to confirm one thing... I have checked all of this patchset by > checkpatch.pl and it did not report the overly long line warning. So, I > should still obey the rule of 80 chars one line? checkpatch.pl is completely

Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-02-18 Thread Ruan Shiyang
On 2021/2/18 下午4:32, Christoph Hellwig wrote: On Wed, Feb 17, 2021 at 10:56:11AM +0800, Ruan Shiyang wrote: I'd like to confirm one thing... I have checked all of this patchset by checkpatch.pl and it did not report the overly long line warning. So, I should still obey the rule of 80 chars

Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-02-16 Thread Ruan Shiyang
On 2021/2/10 下午9:33, Christoph Hellwig wrote: +extern int mf_dax_mapping_kill_procs(struct address_space *mapping, pgoff_t index, int flags); No nee for the extern, please avoid the overly long line. OK. I'd like to confirm one thing... I have checked all of this patchset by

Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-02-10 Thread Christoph Hellwig
> +extern int mf_dax_mapping_kill_procs(struct address_space *mapping, pgoff_t > index, int flags); No nee for the extern, please avoid the overly long line. > @@ -120,6 +121,13 @@ static int hwpoison_filter_dev(struct page *p) > if (PageSlab(p)) > return -EINVAL; > > +

[PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-02-08 Thread Shiyang Ruan
The current memory_failure_dev_pagemap() can only handle single-mapped dax page for fsdax mode. The dax page could be mapped by multiple files and offsets if we let reflink feature & fsdax mode work together. So, we refactor current implementation to support handle memory failure on each file