Re: [PATCH v3 06/17] kthread: use WARN_ON_FUNCTION_MISMATCH

2021-03-25 Thread Kees Cook
On Tue, Mar 23, 2021 at 01:39:35PM -0700, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, a callback function passed to > __kthread_queue_delayed_work from a module points to a jump table > entry defined in the module instead of the one used in the core > kernel, which breaks function address equalit

[PATCH v3 06/17] kthread: use WARN_ON_FUNCTION_MISMATCH

2021-03-23 Thread Sami Tolvanen
With CONFIG_CFI_CLANG, a callback function passed to __kthread_queue_delayed_work from a module points to a jump table entry defined in the module instead of the one used in the core kernel, which breaks function address equality in this check: WARN_ON_ONCE(timer->function != ktead_delayed_work_