Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread David Cohen
On 10/14/2013 09:30 AM, H. Peter Anvin wrote: On 10/14/2013 09:32 AM, David Cohen wrote: Thanks for your feedback. The parameters happen to be similar at this time, but they won't be after next patches. I believe a macro could remove only prefix 'SFI_DEV_TYPE_' and suffix '_platform_data',

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread H. Peter Anvin
On 10/14/2013 09:32 AM, David Cohen wrote: > > Thanks for your feedback. The parameters happen to be similar at this > time, but they won't be after next patches. I believe a macro could > remove only prefix 'SFI_DEV_TYPE_' and suffix '_platform_data', which > seems enough to reduce line size. >

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread H. Peter Anvin
On 10/14/2013 09:16 AM, Joe Perches wrote: > > Another option is to #define YA macro to produce the > SFI_DEV_TYPE_IPC, 1, ... NULL that's common to all of them. > That changes in the next patch, and it wasn't true outside of the subpart of the patch that I quoted, either. -hpa -- To

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread David Cohen
On 10/14/2013 09:16 AM, Joe Perches wrote: On Mon, 2013-10-14 at 09:03 -0700, H. Peter Anvin wrote: On 10/11/2013 08:43 PM, David Cohen wrote: /* MSIC subdevices */ - {"msic_battery", SFI_DEV_TYPE_IPC, 1, _battery_platform_data}, - {"msic_gpio", SFI_DEV_TYPE_IPC, 1,

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread Joe Perches
On Mon, 2013-10-14 at 09:03 -0700, H. Peter Anvin wrote: > On 10/11/2013 08:43 PM, David Cohen wrote: > > > > /* MSIC subdevices */ > > - {"msic_battery", SFI_DEV_TYPE_IPC, 1, _battery_platform_data}, > > - {"msic_gpio", SFI_DEV_TYPE_IPC, 1, _gpio_platform_data}, > > - {"msic_audio",

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread H. Peter Anvin
On 10/11/2013 08:43 PM, David Cohen wrote: > > /* MSIC subdevices */ > - {"msic_battery", SFI_DEV_TYPE_IPC, 1, _battery_platform_data}, > - {"msic_gpio", SFI_DEV_TYPE_IPC, 1, _gpio_platform_data}, > - {"msic_audio", SFI_DEV_TYPE_IPC, 1, _audio_platform_data}, > -

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread H. Peter Anvin
On 10/11/2013 08:43 PM, David Cohen wrote: /* MSIC subdevices */ - {msic_battery, SFI_DEV_TYPE_IPC, 1, msic_battery_platform_data}, - {msic_gpio, SFI_DEV_TYPE_IPC, 1, msic_gpio_platform_data}, - {msic_audio, SFI_DEV_TYPE_IPC, 1, msic_audio_platform_data}, -

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread Joe Perches
On Mon, 2013-10-14 at 09:03 -0700, H. Peter Anvin wrote: On 10/11/2013 08:43 PM, David Cohen wrote: /* MSIC subdevices */ - {msic_battery, SFI_DEV_TYPE_IPC, 1, msic_battery_platform_data}, - {msic_gpio, SFI_DEV_TYPE_IPC, 1, msic_gpio_platform_data}, - {msic_audio,

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread David Cohen
On 10/14/2013 09:16 AM, Joe Perches wrote: On Mon, 2013-10-14 at 09:03 -0700, H. Peter Anvin wrote: On 10/11/2013 08:43 PM, David Cohen wrote: /* MSIC subdevices */ - {msic_battery, SFI_DEV_TYPE_IPC, 1, msic_battery_platform_data}, - {msic_gpio, SFI_DEV_TYPE_IPC, 1,

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread H. Peter Anvin
On 10/14/2013 09:16 AM, Joe Perches wrote: Another option is to #define YA macro to produce the SFI_DEV_TYPE_IPC, 1, ... NULL that's common to all of them. That changes in the next patch, and it wasn't true outside of the subpart of the patch that I quoted, either. -hpa -- To

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread H. Peter Anvin
On 10/14/2013 09:32 AM, David Cohen wrote: Thanks for your feedback. The parameters happen to be similar at this time, but they won't be after next patches. I believe a macro could remove only prefix 'SFI_DEV_TYPE_' and suffix '_platform_data', which seems enough to reduce line size. That

Re: [PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-14 Thread David Cohen
On 10/14/2013 09:30 AM, H. Peter Anvin wrote: On 10/14/2013 09:32 AM, David Cohen wrote: Thanks for your feedback. The parameters happen to be similar at this time, but they won't be after next patches. I believe a macro could remove only prefix 'SFI_DEV_TYPE_' and suffix '_platform_data',

[PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-11 Thread David Cohen
From: Kuppuswamy Sathyanarayanan This patch provides a means to add custom handler for SFI devices. If you set device_handler as NULL in device_id table standard SFI device handler will be used. If its not NULL custom handler will be called. Signed-off-by: Kuppuswamy Sathyanarayanan

[PATCH v3 07/10] intel_mid: Added custom device_handler support

2013-10-11 Thread David Cohen
From: Kuppuswamy Sathyanarayanan sathyanarayanan.kuppusw...@linux.intel.com This patch provides a means to add custom handler for SFI devices. If you set device_handler as NULL in device_id table standard SFI device handler will be used. If its not NULL custom handler will be called.