Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-28 Thread Daniel Scally
Hi Sakari On 28/12/2020 16:41, Sakari Ailus wrote: > Hi Daniel, > > On Thu, Dec 24, 2020 at 02:21:15PM +, Daniel Scally wrote: >> Hi Andy, Laurent >> >>> On Thu, Dec 24, 2020 at 2:55 PM Laurent Pinchart >>> wrote: On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: >

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-28 Thread Sakari Ailus
Hi Daniel, On Thu, Dec 24, 2020 at 02:21:15PM +, Daniel Scally wrote: > Hi Andy, Laurent > > > On Thu, Dec 24, 2020 at 2:55 PM Laurent Pinchart > > wrote: > >> On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: > >>> On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: > > >

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-26 Thread Daniel Scally
Hi Andy On 24/12/2020 12:24, Andy Shevchenko wrote: > On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: >> >> From: Heikki Krogerus >> >> This implements the remaining .graph_* callbacks in the > > .graph_* ==> ->graph_*() ? > >> fwnode operations structure for the software nodes. That

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-24 Thread Daniel Scally
On 24/12/2020 12:53, Laurent Pinchart wrote: >> +while ((port = software_node_get_next_child(parent, old))) { >> +/* >> + * ports have naming style "port@n", so we search for children >> + * that follow that convention (but without assuming anything >> +

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-24 Thread Daniel Scally
Hi Andy, Laurent > On Thu, Dec 24, 2020 at 2:55 PM Laurent Pinchart > wrote: >> On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: >>> On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: > > ... > + if (!strncmp(to_swnode(port)->node->name, "port@", >>> >>>

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-24 Thread Andy Shevchenko
On Thu, Dec 24, 2020 at 2:55 PM Laurent Pinchart wrote: > On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: > > On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: ... > > > + if (!strncmp(to_swnode(port)->node->name, "port@", > > > > You may use here corresponding

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-24 Thread Laurent Pinchart
Hi Andy, On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: > On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: > > > > From: Heikki Krogerus > > > > This implements the remaining .graph_* callbacks in the > > .graph_* ==> ->graph_*() ? > > > fwnode operations structure for

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-24 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Thu, Dec 24, 2020 at 01:09:00AM +, Daniel Scally wrote: > From: Heikki Krogerus > > This implements the remaining .graph_* callbacks in the > fwnode operations structure for the software nodes. That makes > the fwnode_graph*() functions available in

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-24 Thread Andy Shevchenko
On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: > > From: Heikki Krogerus > > This implements the remaining .graph_* callbacks in the .graph_* ==> ->graph_*() ? > fwnode operations structure for the software nodes. That makes > the fwnode_graph*() functions available in the drivers also

[PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-23 Thread Daniel Scally
From: Heikki Krogerus This implements the remaining .graph_* callbacks in the fwnode operations structure for the software nodes. That makes the fwnode_graph*() functions available in the drivers also when software nodes are used. The implementation tries to mimic the "OF graph" as much as