Re: [PATCH v3 08/11] gpio: sim: new testing module

2021-03-12 Thread Andy Shevchenko
On Fri, Mar 12, 2021 at 09:54:58AM +0100, Bartosz Golaszewski wrote: > On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko > wrote: ... > > > + ret = sprintf(page, "n/a\n"); > > > > I dunno '/' (slash) is a good character to be handled in a shell. > > I would prefer 'none' or 'not availa

Re: [PATCH v3 08/11] gpio: sim: new testing module

2021-03-12 Thread Bartosz Golaszewski
On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko wrote: > [snip] > > + > > +static ssize_t gpio_sim_sysfs_line_show(struct device *dev, > > + struct device_attribute *attr, > > + char *buf) > > +{ > > + struct gpio_sim_at

Re: [PATCH v3 08/11] gpio: sim: new testing module

2021-03-10 Thread Linus Walleij
On Tue, Mar 9, 2021 at 9:59 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Implement a new, modern GPIO testing module controlled by configfs > attributes instead of module parameters. The goal of this driver is > to provide a replacement for gpio-mockup that will be easily extens

Re: [PATCH v3 08/11] gpio: sim: new testing module

2021-03-10 Thread Andy Shevchenko
On Tue, Mar 09, 2021 at 09:59:18PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Implement a new, modern GPIO testing module controlled by configfs > attributes instead of module parameters. The goal of this driver is > to provide a replacement for gpio-mockup that will be eas

[PATCH v3 08/11] gpio: sim: new testing module

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Implement a new, modern GPIO testing module controlled by configfs attributes instead of module parameters. The goal of this driver is to provide a replacement for gpio-mockup that will be easily extensible with new features and doesn't require reloading the module to ch