Re: [PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-14 Thread Maxime Ripard
On Thu, Dec 14, 2017 at 11:30:21AM +0800, Chen-Yu Tsai wrote: > >> > + /* Map output pins to channel 0 */ > >> > + regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG, > >> > + SUN4I_TCON_GCTL_IOMAP_MASK, > >> > + SUN4I_TCON_GCTL_IOMAP_TC

Re: [PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-13 Thread Chen-Yu Tsai
On Thu, Dec 7, 2017 at 8:25 PM, Maxime Ripard wrote: > Hi, > > On Thu, Dec 07, 2017 at 02:05:47PM +0800, Chen-Yu Tsai wrote: >> > +static void sun4i_tcon_lvds_set_status(struct sun4i_tcon *tcon, >> > + const struct drm_encoder *encoder, >> > +

Re: [PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-07 Thread Maxime Ripard
Hi, On Thu, Dec 07, 2017 at 02:05:47PM +0800, Chen-Yu Tsai wrote: > > +static void sun4i_tcon_lvds_set_status(struct sun4i_tcon *tcon, > > + const struct drm_encoder *encoder, > > + bool enabled) > > +{ > > + if (enabl

Re: [PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-07 Thread Maxime Ripard
Hi, On Thu, Dec 07, 2017 at 11:14:27AM +0100, Philippe Ombredanne wrote: > On Tue, Dec 5, 2017 at 4:10 PM, Maxime Ripard > wrote: > > The TCON supports the LVDS interface to output to a panel or a bridge. > > Let's add support for it. > > > > Signed-off-by: Maxime Ripard > [] > > --- /dev/null >

Re: [PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-07 Thread Philippe Ombredanne
On Tue, Dec 5, 2017 at 4:10 PM, Maxime Ripard wrote: > The TCON supports the LVDS interface to output to a panel or a bridge. > Let's add support for it. > > Signed-off-by: Maxime Ripard [] > --- /dev/null > +++ b/drivers/gpu/drm/sun4i/sun4i_lvds.c > @@ -0,0 +1,183 @@ > +/* > + * Copyright (C) 20

Re: [PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-06 Thread Chen-Yu Tsai
On Tue, Dec 5, 2017 at 11:10 PM, Maxime Ripard wrote: > The TCON supports the LVDS interface to output to a panel or a bridge. > Let's add support for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/sun4i/Makefile | 1 +- > drivers/gpu/drm/sun4i/sun4i_lvds.c | 183

[PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-05 Thread Maxime Ripard
The TCON supports the LVDS interface to output to a panel or a bridge. Let's add support for it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/Makefile | 1 +- drivers/gpu/drm/sun4i/sun4i_lvds.c | 183 +++- drivers/gpu/drm/sun4i/sun4i_lvds.h | 18 ++- drivers/