Re: [PATCH v3 09/11] mips: Use STACK_TOP when computing mmap base address

2019-04-17 Thread Alex Ghiti
On 4/18/19 1:31 AM, Kees Cook wrote: On Wed, Apr 17, 2019 at 12:32 AM Alexandre Ghiti wrote: mmap base address must be computed wrt stack top address, using TASK_SIZE is wrong since STACK_TOP and TASK_SIZE are not equivalent. Signed-off-by: Alexandre Ghiti Acked-by: Kees Cook Thanks !

Re: [PATCH v3 09/11] mips: Use STACK_TOP when computing mmap base address

2019-04-17 Thread Kees Cook
On Wed, Apr 17, 2019 at 12:32 AM Alexandre Ghiti wrote: > > mmap base address must be computed wrt stack top address, using TASK_SIZE > is wrong since STACK_TOP and TASK_SIZE are not equivalent. > > Signed-off-by: Alexandre Ghiti Acked-by: Kees Cook -Kees > --- > arch/mips/mm/mmap.c | 4 ++--

[PATCH v3 09/11] mips: Use STACK_TOP when computing mmap base address

2019-04-16 Thread Alexandre Ghiti
mmap base address must be computed wrt stack top address, using TASK_SIZE is wrong since STACK_TOP and TASK_SIZE are not equivalent. Signed-off-by: Alexandre Ghiti --- arch/mips/mm/mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/mm/mmap.c b/arch/mips/mm/m