Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management

2012-10-01 Thread Glauber Costa
On 10/01/2012 04:36 PM, Michal Hocko wrote: > On Mon 01-10-12 16:29:11, Glauber Costa wrote: >> On 10/01/2012 04:15 PM, Michal Hocko wrote: >>> Based on the previous discussions I guess this one will get reworked, >>> right? >>> >> >> Yes, but most of it stayed. The hierarchy part is gone, but beca

Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management

2012-10-01 Thread Michal Hocko
On Mon 01-10-12 16:29:11, Glauber Costa wrote: > On 10/01/2012 04:15 PM, Michal Hocko wrote: > > Based on the previous discussions I guess this one will get reworked, > > right? > > > > Yes, but most of it stayed. The hierarchy part is gone, but because we > will still have kmem pages floating ar

Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management

2012-10-01 Thread Glauber Costa
On 10/01/2012 04:15 PM, Michal Hocko wrote: > Based on the previous discussions I guess this one will get reworked, > right? > Yes, but most of it stayed. The hierarchy part is gone, but because we will still have kmem pages floating around (potentially), I am still using the mark_dead() trick wi

Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management

2012-10-01 Thread Michal Hocko
Based on the previous discussions I guess this one will get reworked, right? On Tue 18-09-12 18:04:06, Glauber Costa wrote: > Because the assignment: memcg->kmem_accounted = true is done after the > jump labels increment, we guarantee that the root memcg will always be > selected until all call si

[PATCH v3 09/13] memcg: kmem accounting lifecycle management

2012-09-18 Thread Glauber Costa
Because the assignment: memcg->kmem_accounted = true is done after the jump labels increment, we guarantee that the root memcg will always be selected until all call sites are patched (see memcg_kmem_enabled). This guarantees that no mischarges are applied. Jump label decrement happens when the la