Re: [PATCH v3 09/17] mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table()

2020-05-05 Thread Rajendra Nayak
On 5/5/2020 5:03 PM, Ulf Hansson wrote: On Wed, 29 Apr 2020 at 16:09, Rajendra Nayak wrote: On 4/28/2020 11:59 PM, Ulf Hansson wrote: On Tue, 28 Apr 2020 at 15:39, Rajendra Nayak wrote: Even though specifying OPP's in device tree is optional, ignoring all errors reported by dev_pm_opp_o

Re: [PATCH v3 09/17] mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table()

2020-05-05 Thread Ulf Hansson
On Wed, 29 Apr 2020 at 16:09, Rajendra Nayak wrote: > > > On 4/28/2020 11:59 PM, Ulf Hansson wrote: > > On Tue, 28 Apr 2020 at 15:39, Rajendra Nayak wrote: > >> > >> Even though specifying OPP's in device tree is optional, ignoring all > >> errors > >> reported by dev_pm_opp_of_add_table() means

Re: [PATCH v3 09/17] mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table()

2020-04-29 Thread Rajendra Nayak
On 4/28/2020 11:59 PM, Ulf Hansson wrote: On Tue, 28 Apr 2020 at 15:39, Rajendra Nayak wrote: Even though specifying OPP's in device tree is optional, ignoring all errors reported by dev_pm_opp_of_add_table() means we can't distinguish between a missing OPP table and a wrong/buggy OPP table.

Re: [PATCH v3 09/17] mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table()

2020-04-28 Thread Ulf Hansson
On Tue, 28 Apr 2020 at 15:39, Rajendra Nayak wrote: > > Even though specifying OPP's in device tree is optional, ignoring all errors > reported by dev_pm_opp_of_add_table() means we can't distinguish between a > missing OPP table and a wrong/buggy OPP table. While missing OPP table > (dev_pm_opp_o

[PATCH v3 09/17] mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table()

2020-04-28 Thread Rajendra Nayak
Even though specifying OPP's in device tree is optional, ignoring all errors reported by dev_pm_opp_of_add_table() means we can't distinguish between a missing OPP table and a wrong/buggy OPP table. While missing OPP table (dev_pm_opp_of_add_table() returns a -ENODEV in such case) can be ignored, a